Re: [PATCH v3 06/32] Mini-OS: add EXPORT_SYMBOL() instances to mm.c

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Juergen Gross, le lun. 27 nov. 2023 11:24:57 +0100, a ecrit:
> Add the needed instances of EXPORT_SYMBOL() to mm.c.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
> V3:
> - new patch
> ---
>  arch/arm/mm.c | 2 ++
>  arch/x86/mm.c | 5 +++++
>  mm.c          | 4 ++++
>  3 files changed, 11 insertions(+)
> 
> diff --git a/arch/arm/mm.c b/arch/arm/mm.c
> index 11962f8b..c269ab14 100644
> --- a/arch/arm/mm.c
> +++ b/arch/arm/mm.c
> @@ -85,6 +85,7 @@ int do_map_frames(unsigned long addr,
>  {
>      return -ENOSYS;
>  }
> +EXPORT_SYMBOL(do_map_frames);
>  
>  /* Get Xen's suggested physical page assignments for the grant table. */
>  static paddr_t get_gnttab_base(void)
> @@ -149,3 +150,4 @@ unsigned long map_frame_virt(unsigned long mfn)
>  {
>      return mfn_to_virt(mfn);
>  }
> +EXPORT_SYMBOL(map_frame_virt);
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index cfc978f6..767a5f07 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -493,6 +493,7 @@ pgentry_t *need_pgt(unsigned long va)
>      offset = l1_table_offset(va);
>      return &tab[offset];
>  }
> +EXPORT_SYMBOL(need_pgt);
>  
>  /*
>   * Reserve an area of virtual address space for mappings and Heap
> @@ -634,6 +635,7 @@ int do_map_frames(unsigned long va,
>  
>      return 0;
>  }
> +EXPORT_SYMBOL(do_map_frames);
>  
>  /*
>   * Map an array of MFNs contiguous into virtual address space. Virtual
> @@ -654,6 +656,7 @@ void *map_frames_ex(const unsigned long *mfns, unsigned 
> long n,
>  
>      return (void *)va;
>  }
> +EXPORT_SYMBOL(map_frames_ex);
>  
>  /*
>   * Unmap nun_frames frames mapped at virtual address va.
> @@ -724,6 +727,7 @@ int unmap_frames(unsigned long va, unsigned long 
> num_frames)
>      }
>      return 0;
>  }
> +EXPORT_SYMBOL(unmap_frames);
>  
>  /*
>   * Clear some of the bootstrap memory
> @@ -859,3 +863,4 @@ unsigned long map_frame_virt(unsigned long mfn)
>  
>      return addr;
>  }
> +EXPORT_SYMBOL(map_frame_virt);
> diff --git a/mm.c b/mm.c
> index 6493bdd4..eb0e34de 100644
> --- a/mm.c
> +++ b/mm.c
> @@ -280,6 +280,7 @@ unsigned long alloc_pages(int order)
>  
>      return 0;
>  }
> +EXPORT_SYMBOL(alloc_pages);
>  
>  void free_pages(void *pointer, int order)
>  {
> @@ -336,6 +337,7 @@ void free_pages(void *pointer, int order)
>      free_head[order] = freed_ch;   
>     
>  }
> +EXPORT_SYMBOL(free_pages);
>  
>  int free_physical_pages(xen_pfn_t *mfns, int n)
>  {
> @@ -352,6 +354,7 @@ int map_frame_rw(unsigned long addr, unsigned long mfn)
>  {
>      return do_map_frames(addr, &mfn, 1, 1, 1, DOMID_SELF, NULL, L1_PROT);
>  }
> +EXPORT_SYMBOL(map_frame_rw);
>  
>  #ifdef HAVE_LIBC
>  void *sbrk(ptrdiff_t increment)
> @@ -385,6 +388,7 @@ void *sbrk(ptrdiff_t increment)
>  
>      return (void *) old_brk;
>  }
> +EXPORT_SYMBOL(sbrk);
>  #endif
>  
>  
> -- 
> 2.35.3
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.