Re: [PATCH v3 06/14] xen/asm-generic: introduce generic header percpu.h

[Julien Grall <julien@xxxxxxx>]

Hi Oleksii,

On 17/11/2023 12:24, Oleksii Kurochko wrote:
> The patch introduces generic percpu.h which was based on Arm's version
> with the following changes:
>   * makes __per_cpu_data_end[] constant
>   * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr()
>   * add inclustion of <asm/current.h> as get_per_cpu_offset() is located there.
>
> Also it was changed a place where <asm/percpu.h> is included in <xen/percpu.h>
> because asm-generic version of percpu.h started to include <asm/current.h> which
> requires definition of DECLARE_PER_CPU.
>
> As well the patch switches Arm, PPC and x86 architectures to use asm-generic
> version of percpu.h.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V3:
>   - switch all architectures to asm-generic version of percpu.h
>   - introduce get_per_cpu_offset() and implement it architectures.
>   - make __per_cpu_data_end constamt.
>   - update the commit message.
> ---
> Changes in V2:
>         - use smp_processor_id() instead of get_processor_id().
>         - update commit message .
> ---
>   xen/arch/arm/include/asm/Makefile             |  1 +
>   xen/arch/arm/include/asm/current.h            |  3 +++
The changes for Arm and common looks good to me. I saw Jan thought the 
include movement is fragile, I don't have any strong opinion about the 
placement so long it compiles :). So feels free to add my ack:
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall