Re: [PATCH v2 01/13] xen/spinlock: fix coding style issues

[Juergen Gross <jgross@xxxxxxxx>]

On 18.10.23 17:47, Jan Beulich wrote:
> On 13.10.2023 11:42, Juergen Gross wrote:
> > Fix some coding style issues in spinlock coding:
> >
> > - Instead of u64 etc. use the preferred uint64_t etc. types
> > - Remove some trailing spaces
> > - Add missing spaces in "if" statements
> > - Add some missing blank lines
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one possible further request:
>
> > @@ -298,7 +298,7 @@ static always_inline spinlock_tickets_t 
> > observe_lock(spinlock_tickets_t *t)
> >       return v;
> >   }
> >   
> > -static always_inline u16 observe_head(spinlock_tickets_t *t)
> > +static always_inline uint16_t observe_head(spinlock_tickets_t *t)
> While there, could you also add const to the pointed-to parameter type?
> t, after all, ...
>
> >   {
> >       smp_rmb();
> >       return read_atomic(&t->head);
> ... is only read through. (I'd also be happy for this to be adjusted on
> commit, so long as you agree.)
I agree.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature