Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1

[Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>]

Hi,

On Tue, Aug 08, 2023 at 03:08:04PM +0200, Jan Beulich wrote:
> On 08.08.2023 15:03, Alejandro Vallejo wrote:
> > --- a/xen/arch/x86/cpu/microcode/core.c
> > +++ b/xen/arch/x86/cpu/microcode/core.c
> > @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long 
> > *module_map,
> >          return -ENODEV;
> >      }
> >  
> > -    microcode_grab_module(module_map, mbi);
> > -
> >      ucode_ops.collect_cpu_info();
> >  
> > +    /*
> > +     * Some hypervisors deliberately report a microcode revision of -1 to
> > +     * mean that they will not accept microcode updates. We take the hint
> > +     * and ignore the microcode interface in that case.
> > +     */
> > +    if ( this_cpu(cpu_sig).rev == ~0 )
> > +    {
> > +        printk(XENLOG_WARNING "Microcode loading disabled due to: %s",
> > +                              "rev = ~0");
> 
> Sadly there now looks to be a newline missing. Easy to add while committing,
> I suppose, and with it added (back)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Jan
You mean the missing newline after "%s"? It fell under the cracks
while adding the substring in v6. It should indeed be there, cheers.

Thanks,
Alejandro