Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test

[Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>]

Jan Beulich:
> On 31.07.2023 12:32, Simon Gaiser wrote:
>> --- a/xen/arch/x86/io_apic.c
>> +++ b/xen/arch/x86/io_apic.c
>> @@ -1967,6 +1967,8 @@ static void __init check_timer(void)
>>  
>>              if ( timer_irq_works() )
>>              {
>> +                printk(XENLOG_INFO "IRQ test with HPET Legacy Replacement 
>> Mode worked. Disabling it again.\n");
>> +                hpet_disable_legacy_replacement_mode();
>>                  local_irq_restore(flags);
>>                  return;
>>              }
> 
> I'm not sure of the value of the log message. Furthermore, considering
> plans to make XENLOG_INFO visible by default in release builds, when
> not purely a debugging message. I'm curious what other x86 maintainers
> think ...

As far as I can see nobody has so far voiced an opinion. How about you
tell me the level and message you would prefer and I send a new version
of the patch with it.

Simon

Attachment: OpenPGP_signature
Description: OpenPGP digital signature