Re: [XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 3 Aug 2023, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> 
> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline
> states:
> "The lowercase character 'l' shall not be used in a literal suffix".
> 
> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity.
> If the "u" suffix is used near "L", use the "U" suffix instead, for 
> consistency.
> 
> The changes in this patch are mechanical.
> 
> Signed-off-by: Gianluca       Luparini <gianluca.luparini@xxxxxxxxxxx>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/arch/x86/hvm/svm/svm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index b3845bdca7..01dd592d9b 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1077,7 +1077,7 @@ static void svm_guest_osvw_init(struct domain *d)
>       * Guests should see errata 400 and 415 as fixed (assuming that
>       * HLT and IO instructions are intercepted).
>       */
> -    svm->osvw.length = min(max(3ul, osvw_length), 64ul);
> +    svm->osvw.length = min(max(3UL, osvw_length), 64UL);
>      svm->osvw.status = osvw_status & ~6;
>  
>      /*
> @@ -1652,7 +1652,7 @@ static void svm_do_nested_pgfault(struct vcpu *v,
>      else if ( pfec & NPT_PFEC_in_gpt )
>          npfec.kind = npfec_kind_in_gpt;
>  
> -    ret = hvm_hap_nested_page_fault(gpa, ~0ul, npfec);
> +    ret = hvm_hap_nested_page_fault(gpa, ~0UL, npfec);
>  
>      if ( tb_init_done )
>      {
> -- 
> 2.34.1
> 
>