[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/gnttab: Purge PIN_FAIL()
On 13/06/2023 18:32, Julien Grall wrote: On 13/06/2023 17:52, Andrew Cooper wrote:This is disliked specifically by MISRA, but it also interferes with code legibility by hiding control flow. Expand and drop it. > * Drop redundant "rc = rc" assignment * Rework gnttab_copy_buf() to be simpler by dropping the rc variable No functional change. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx> Just one remark. It would be useful to mention the MISRA rule. This helps to find which one you are talking about. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |