[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: un-break build with clang
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 25 May 2023 19:05:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4GbgPiS1x1TpkNVAqOrkzAGX47h2muemCOuyQR/UaY=; b=IuMBNPvqbv9HjezK4fD+RZMpJToUd3GJO+3PSpk/sjQiIRrPzu15Chdj/+dGGjEIcOLnJ/Oj1v7slPaIE5K2n8SiDPc7DXCQYMSDshsG4u8KTK6inc7zPy5GamXocTFeKvWqAl6C6zGltbC+jq17XJBgYj+CGqgwo/r0I0j/RfsRzWTRQgBjcqqpzfbkcsUiqaShXX3K+9CyqWlbjbYZMstNyRSJMFf5MUIzIR03TRSjvpoS6Pn5iOmazICqeKJshnWUcIHwKV6GZoHL9Q+IzyTULh/3iJoSVUuV2hAl5Sdh+9oMqtUuW3NVKTiDg/nQOpTRgct3U9sSBdYe44MdEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dE3CNVTCa/Kk8b23yaEaskfbs7L1QcGK7grB9f9Z4g4qfkW9dzfGYyj09PmmxmddUNNpssMbCRbpWyndYZIiuKVsoLr0lJFVv9dLz2w3GlLDWspVaRloU4BsRzCjjob3mcGFlxyrVojx07/1kxsSRse7T8OaGqofcviyJeKr8M3PfDMwUTmIB+wQtADlXRUAkLJsL6Yx7G+LVjct4DReFevZ+zcip2Psq39Z6VGL0eQe7OhLIjco3XIBd0EuJxmfp31sFZseB9Z+LIAxsty3AuRLChuCAUAAMrhza/lZObM1eduXUSbZMB068oxZeH6F6mIJX0KnOuOEtl4qsB9e9A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 25 May 2023 18:06:01 +0000
- Ironport-data: A9a23:lYJUHq1LZhZzJoikHfbD5XRwkn2cJEfYwER7XKvMYLTBsI5bpz1Tm zYXWT+FO/eINDPxc9wlOozgp0lQ6JOHmNNqSAs5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gFkOKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfPXMJy K0bDjs2bAGi3uCXwbGDCedDmZF2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjCdhKT+TkrpaGhnWz2UEQUkZLWmG0hvWeinCgae8OM lMtr39GQa8asRbDosPGdwakrWGNpAJaW9tUH+Aw8giLxoLd5grfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaETMOMWYIaCsATA0Ey9ruuoc+ilTIVNkLOKyoitz4Hxngz jbMqzIx750ZgNQXzay98RbCiii1u5nSZgcv40PcWWfNxj1+YImpdom582/x5PxLLJuaZlSZt X1CkM+bhMgMB5yQkC2GQM0WAaqkof2CNVX0nlpHD5QnsTO39BaekZt45Th/IAJjNJYCcDqwO UvL41oPtdlUIWegarJxb8SpEcM2wKP8FNPjEPfJct5JZZs3fwiClM1zWXOtM6nWuBBEuckC1 V2zK65A0V5y5Xxb8QeL
- Ironport-hdrordr: A9a23:fqnAFK9NaZoLIbBvdYVuk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M 5bAsxD4QTLfDpHsfo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/05/2023 6:51 pm, Stewart Hildebrand wrote:
> diff --git a/xen/arch/arm/include/asm/setup.h
> b/xen/arch/arm/include/asm/setup.h
> index 38e2ce255fcf..af53e58a6a07 100644
> --- a/xen/arch/arm/include/asm/setup.h
> +++ b/xen/arch/arm/include/asm/setup.h
> @@ -168,13 +168,13 @@ u32 device_tree_get_u32(const void *fdt, int node,
> int map_range_to_domain(const struct dt_device_node *dev,
> u64 addr, u64 len, void *data);
>
> -extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
> +EXTERN_DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
The problem is using DEFINE_$blah() when you mean DECLARE_$blah().
They're split everywhere else in Xen for good reason.
But the macro looks like pure obfuscation to start with. It should just
be a simple
extern lpae_t boot_pgtable[XEN_PT_LPAE_ENTRIES];
The declaration shouldn't have an alignment or section attribute on, and
deleting the macro makes the header easier to read.
~Andrew
|
