[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cmdline: document "extra_guest_irqs" upper bound


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 4 Apr 2023 08:09:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wFGQFCHVvkmCrHJ1jX9q5LMd/o9f8WZjGtAJf7Jd0UE=; b=hg6On8P1fYABJ+Q9Pns0LSJaW0DLCCB1B3GA573Y7dl0NSEF+SlxrN0F44MzHWKQBDcLUbr3qMFpHuE+2CaYnKVJ6Et7tUV1Brgio2LfrtFbCHF0uYWXVYnAi+hygKTbSvZVXOOmy/HMxsx0eR/qcYqtWhC52X5zKk9jPZTUOBwifFTSIZo/sqVbMIaokzhs23U4JBxOH6+nmfftQNxusyjXsKCJ9h0Alt33VEqhzBmAbiJUGOjGdh0Ra4Wka5zOVj0iHj3KzOUuWGvZP5cTtpnH+15skuP+i6bcB5r4CAfTHplcDiORRgSYWUeHd/BRUU20M7gRPHemwAxqekLzrg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAd9ThiVB1C/euKnE+DNBs86UG+rK+QzGvc4Qy+vcHCkQlfSpokUaK/PuMKk812NYbwjt/+XwCiqXiGTBa6oW/mNrPGlyX4ngPf+1k/xXjWJD/dDUbdykrpBTxjd5/J7sGTjXDeDSEg3aduIce8XooOgVPM0j6IyHyNs1nZboYO3qW55gY7PXz5Htld4B/YImUQGbUqy5QrtJRg8oWqUWNRbfDcKMXTnZdOtlM2XI701ACoucXhBU9Kj14wlI5tqxpat3x38b4XSq9GambHru80NkMfWRiSBCCjPsVDTLrfApJnDWT0l0z7tHdoDKoYHbkAU9QFC2IpD+/IietN7Cw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 04 Apr 2023 07:09:46 +0000
  • Ironport-data: A9a23:d+uY0aktrPm+dP20RudmKQro5gxUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKXmyCb//ZYWKmKNojaY6zoEgP7MeAmIc2Sgtkqi5mECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgX5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c4nISEWcg2vvt67+Iird+dF3/kRAda+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieC9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOHmraA70Qf7Kmo7AzEdWQCHpMuFmFedXdsBE 1I/xSYllP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2GEUvvhjutot3MUVQz7wCOBma9tFohNMiiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrlxBJ1bLkVhs3QxD
  • Ironport-hdrordr: A9a23:oOtNSKvU+dmVJ4hhy/vsqf6A7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/04/2023 7:46 am, Jan Beulich wrote:
> PHYSDEVOP_pirq_eoi_gmfn_v<N> accepting just a single GFN implies that no
> more than 32k pIRQ-s can be used by a domain. Document this upper bound.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
> I was uncertain about also introducing a bounds check in code: We don't
> check for bogus / abusive values elsewhere either.

Normally not, but in this case I suspect it's worth it.  Without a
bounds check, don't we risk wandering off the page?




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.