Re: [PATCH v2 2/4] xen: change <asm/bug.h> to <xen/bug.h>

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Thu, 2023-02-23 at 14:34 +0100, Jan Beulich wrote:
> On 20.02.2023 17:40, Oleksii Kurochko wrote:
> > --- a/xen/include/xen/lib.h
> > +++ b/xen/include/xen/lib.h
> > @@ -24,12 +24,12 @@
> >  
> >  #ifndef __ASSEMBLY__
> >  
> > +#include <xen/bug.h>
> >  #include <xen/inttypes.h>
> >  #include <xen/stdarg.h>
> >  #include <xen/types.h>
> >  #include <xen/xmalloc.h>
> >  #include <xen/string.h>
> > -#include <asm/bug.h>
> >  
> >  #define BUG_ON(p)  do { if (unlikely(p)) BUG();  } while (0)
> >  #define WARN_ON(p)  ({                  \
> 
> As just said in reply to patch 1 - I can't see how this would build
> at this point. There looks to be an ordering problem; you first need
> to remove from asm/bug.h what's now also available from xen/bug.h.
> Possibly parts of patches 3 and 4 need to move here.
Yeah, you are right as I answared to your reply to patch 1. I missed
that because I tested only RISC-V and didn't run tests for all
architectures.

I'll remove generic parts from patches 3 and 4 to patch 2 and will add
define BUG_FRAME_STRUCT to asm/bug.h specific headers.
> 
> Jan
~ Oleksii