Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS

[Julien Grall <julien@xxxxxxx>]

Hi,

On 08/02/2023 07:40, Jan Beulich wrote:
> On 08.02.2023 05:51, Demi Marie Obenour wrote:
> > --- a/xen/drivers/passthrough/pci.c
> > +++ b/xen/drivers/passthrough/pci.c
> > @@ -11,7 +11,7 @@
> >    * more details.
> >    *
> >    * You should have received a copy of the GNU General Public License along 
> > with
> > - * this program; If not, see <http://www.gnu.org/licenses/>.
> > + * this program; If not, see <https://www.gnu.org/licenses/>.
> >    */
> >   
> >   #include <xen/sched.h>
> At the example of this file: While the above matches $subject, ...
>
> > @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev)
> >            * Device [8086:2fc0]
> >            * Erratum HSE43
> >            * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset
> > -         * 
> > https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html
> > +         * 
> > https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html
> >            */
> >           { PCI_VENDOR_ID_INTEL, 0x2fc0 },
> >           /*
> >            * Devices [8086:6f60,6fa0,6fc0]
> >            * Errata BDF2 / BDX2
> >            * PCI BARs in the Home Agent Will Return Non-Zero Values During 
> > Enumeration
> > -         * 
> > https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
> > +         * 
> > https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
> >           */
> >           { PCI_VENDOR_ID_INTEL, 0x6f60 },
> >           { PCI_VENDOR_ID_INTEL, 0x6fa0 },
> ... this doesn't (and would rather belong in the earlier patch).
>
> As to $subject: Wouldn't it be more logical to replace the license boiler
> plates by SPDX headers instead? This was done to some degree on Arm
> already, but I haven't gone check why it was done incompletely there.
Skimming through xen-devel, it sounds like it was most likely a lack of 
time. I think it would be a good idea here to switch to SPDX.
That said, I can appreciate that Demi may not want to take on that 
works. So I would be happy to give a try if no-one else wants to.
Cheers,

--
Julien Grall