[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 6 Feb 2023 17:53:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BA3hVnymw75XyzT28ezWDicOIUf4EVaML1zrA+X2Bsw=; b=bSjsUcFw3dQRJH/AGnG5wkvdLjwnLN6tIYtyTCAarw1Lj7ElCaX+tq3BhDGhCJO9Uzwr8I/XlLbT3Qr/9WeFtwE/gkwjePYbP0xe0OvQiB3zsn+kj45z38KGAxONgG5oM4slQDm18u1HZQpS7H3bU23W5NW9s/qxVK/miwM8KK055ZeED2YI//x/8B21yM3ZLYQQ5HYrIptRoRto+mDENAXt84NCZK+LXHXN0iLSEj+pVuk3YlOzJZkpJcnf9Kojh4GvlaPMuJRO8U5JgtPKJ4GzOQCkVOzS1dffTbeRIbnVH0+/TR0T0NfU/zCR6xRs1Wj2P81/Q1trM28/SXFjpQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+8xERCtl8nVH50N8rKZRFdyeJDfXgSQ6s1MNwqMKBGzefZFSShiRsJM8CXeR53sfC//JO5+4Ns0nv46xccQUjj2GNyTT2eIp8OcQUFbTUc5UIXMfNwsehEA7supdcMgNfqlDl4N8x+vRuPdJKcNywQiajoQF50OKnMTKrzUy+SD5IR5HuJjw53iA+CoYq/YYRnCJ8dkiTpAvff8pmWY1QppI82qphbhwg5BeFm4bPqOUyNEgyJagVSV58TG/1gIS7SiqZ4G2I5FSvyOHVLgetqa6qa4EKlntQqy+SxejQlH/vfeUSPsm+Qf2Ax9C2GbzboMpn4nMzZhHIQNtFCZSw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 06 Feb 2023 16:53:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.02.2023 17:30, Xenia Ragiadakou wrote:
> On 2/6/23 15:11, Xenia Ragiadakou wrote:
>> On 2/6/23 15:01, Jan Beulich wrote:
>>> On 06.02.2023 13:42, Xenia Ragiadakou wrote:
>>>> --- a/xen/arch/x86/emul-i8254.c
>>>> +++ b/xen/arch/x86/emul-i8254.c
>>>> @@ -34,7 +34,7 @@
>>>> #include <asm/time.h>
>>>> #include <asm/hvm/hvm.h>
>>>> #include <asm/hvm/io.h>
>>>> -#include <asm/hvm/support.h>
>>>> +#include <asm/hvm/save.h>
>>>> #include <asm/hvm/vpt.h>
>>>> #include <asm/current.h>
>>>
>>> To be honest I'd prefer if only the HVM-specific part of this file had
>>> this new #include (and ideally the other hvm/ ones would move there as
>>> well, but I can see this being beyond the scope of what you're wanting
>>> to do).
>>
>> Ah I see. That's ok. I ll move it in v2.
>
> After having a closer look at the code, I think it would be better to
> leave it as is in this patch because the struct hvm_hw_pit_channel
> (declared in puplic/hvm/save.h) and the function hvm_get_guest_time()
> (declared in asm/hvm/hvm.h) are used by the common part of this file.
> And I can send another patch to cleanup the headers in this file.
> Unless you insist.
Oh, I didn't recall it's this ugly. We're indeed using a HVM-only struct
for PV here as well. Your change is okay then as is:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
