Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from <asm/bug.h>

[Julien Grall <julien@xxxxxxx>]

On 03/02/2023 13:15, Oleksii wrote:
> Hi Julien,
Hi Oleksii,

> On Wed, 2023-02-01 at 22:11 +0000, Julien Grall wrote:
> I am trying to introduce GENERIC_BUG_FRAME config ( only for ARM now as
> some stuff isn't available now for RISC-V such as find_text_region(),
> printk() and so on... Thereby I will switch to do_bug_frame() to
> generic one a little bit later for RISCV ) so I added the following to
> Kconfig:
>
>      config GENERIC_DO_BUG_FRAME
>         bool "Generic implementation of do_bug_frame()"
>         default y if ARM
>         default n
>         help
>           ...
>
> But when I pushed the commit to GitLab all ARM randconfig jobs failed
> because they decided not to set GENERIC_BUG_FRAME=y.
> Could you please give me a suggestion how I can work around this
> problem? ( I thought that it would be enough to use default y but
> randconfig can override it ).
You don't want to allow the user to deselect GENERIC_DO_BUG_FRAME. So
you want config ARM to select it:

(arch/arm/Kconfig)
config ARM
   ...
   select GENERIC_DO_BUG_FRAME


(common/Kconfig)
config GENERIC_DO_BUG_FRAME
   bool

> Or is it needed to provide an empty implementation for do_bug_frame()
> GENERIC_BUG_FRAME=n?
> Also I thought about weak function as an option...
>
> Here is pipeline for generic bug frame feature and the patch ( of
> course not ready for upstream but at least it shows an idea ):
>   *
> https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/766581174
>   *
> https://gitlab.com/xen-project/people/olkur/xen/-/commit/6fc6481202852e0aa2c2cb3877f2d71ac0213511
>   
> P.S.: Probably you have some comments ( something that is unacceptable
> even now ) about the patch. I will happy to hear them too.
I will try to have a look next week.

Cheers,

--
Julien Grall