[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 31 Jan 2023 10:34:24 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+PlCKXgtw66fgXDbozMa0qLuW7sUDRE/I1XW0+CKPg=; b=VsMFxG4zcga4qWvn97xvr7hqqfi3GPBQPtP2bGfwPSmU/LE+jGbRXwPA3xXQFHcJjlPECJKnpgEwqMuswlAp/BXWBPzgpQY7HGhOhZfQNeGhs2Sa/u3r3k5t9riRIpZoJrbcGTBA+EOJsaoM3SosZriNF3yXoh9W2yzGkmg+n7M1msmAw86VY5hHM/vh7KcHtuH1a4XvubK4YF/6ESWc4I2FdyMOGHXwVF3bguOr1eqo/QdqZBxXqgpKMzIEiwup+VDJD/4m5n06je0K9jPFQYES7nqrYqpftSV1ohFOZOoF/V9VxptE028WOH74B1e48ntGX02PmGuvzOEYG5Q9fw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODIHzNUxNeNKibGytfkT/fU5kSu6KsFYiimQC+qA0LY7TuAx7j7eisWScaMcKJwQb+HxF9vdgTKZaBehz/8IAWol1XontBPMyjOb2gl5GfkGBSEnrt4eo2Zs84PteEZjWctPzojn7TY4kT8rz423JL98Ix4Vaa30Fwigiy0UcVgK4+GdtWEM0B1u/CaPMCcOwpF9vPOTk2SgBpPgVeMP91W7JqesyDCt0+VrdCEgmw7wEeLAdPTw6jQwJYw5Kvh4989vEfnMpP0DMDeGQsOANjKO4jpogga12i224Jk5SymU7siR5Uh3sT3xnpLyvGBhxE5lGxC8HZpt8K2u2kZ8xg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 31 Jan 2023 09:34:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.01.2023 19:28, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> The lock is not meant to be modified by _rw_is{,_write}_locked(). So
> constify it.
> 
> This is helpful to be able to assert if the lock is taken when the
> underlying structure is const.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
(maybe also Requested-by)

Thanks for doing this on top of the spinlock change.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.