[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 28 Jan 2023 03:41:59 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XGDSjEtfcXizPgazm0/AW6Wagym2+2R8sTT6ABlbzdU=; b=Hfb1lD/1Zg6EN50al9TagK1kVI43fkxJ7b5KhEJ2vNk6t3G4xqxidKjbSoSuBmSeM47I8SyDMW3sOstWxw7NUKpv7uniFeQk7/GX+LMcRZh2oB1gpYRHlNVbxAEtxt5TpAGndYzm2LWCQ51vWC6YOMCwWRcN5AO6+VWOowniMbU1ZUYFzfCXVa11rHGRbw/v9rZv1d7Xl/DqDkw+fENNNiSSf0/402vwNU1j4NKVsxs4wYNRbn3U0QRXLbcVQzSkpVuzKZP3y5fEEEk/4CKvzCy92iQ0JrBzpmqmqDn7VlXzaW0Sw5oXCD4By314vyG+qyjooshuO9aN9CKNhs8Spg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdTS59d+QMaCfHvNCPVH3h0wKQdVgr1OESMSlkOrF7Qumlh4NEpfP+UL5CrK54EhCx3Bqqhy9J+eJTwvxDcBilEKVgSuVfVYHuLyenKUl+tOKjWLXWhH2SXb3KRei+ulSdAUiSACobEwG+YAho90CvDd1EYAyO0zQyXXH5J79XP9nV/O5hAvWKPf7QKMXktp5y7i1qGE3RMay29KNt8iL1RRDe93Hgbza7UrXXv2nNqZcDED83HndvpJWEpKIB5CVwU/0Mqhqtl5+kFQXFVxeifFPPP5izaf/qHV76UXTJdDGuh+ZP8oqH+kpSp59rSHfJmJOUyYFvGfgDP56Heqeg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Sat, 28 Jan 2023 03:42:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZMoEK6Qg1GivE6U2ZJONPV13z5a6zGZ7w
- Thread-topic: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn
Hi Julien,
> -----Original Message-----
> Subject: [PATCH] tools/xenstored: hashtable: Constify the parameters of
> hashfn/eqfn
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The parameters of hashfn/eqfn should never be modified. So constify
> them and propagate the const to the users.
>
> Take the opportunity to solve some coding style issues around the
> code modified.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Tested the build:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|