[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add more rules to docs/misra/rules.rst
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Date: Fri, 27 Jan 2023 10:33:22 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUeS2AzeEXhqUIkTnSCzDW1sKcFG5DEArAfKABQ9hws=; b=MqwGRqLkJNXdmlUS/ryWYQJhTx4uuKSnU6Hb2gqmCcS+24WTYaj/iRUqn4A+hThkBJMZAs7p57qIYG4bwjvkWjLMdXtlF+/hSmfLPVajYsAPSbTCw3RAUz7+9ttaannEPAyBeeEadPW66f1xAV5piQqP+PVvSuLuMm03YZ3LhPq8fqEzpxwKDF392MejEok3ofncd7TT7ldQ87E3d5WJ+sqsb3vZAiMQiuF3FAb1yI+mpWC+BQ5QrQ51GdqOQS0+aYxg7ExClQt69Zegz1cTBdJfdUudAVg68gCZoyy1Bp10NPAolOIkuCAQldOYKxQ0BAnVs92pOHaCLxW7einXpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDpTCARloKEXYb1a1fNoeDgoyBwc2SLNXt5VgNHvEAx9oL0MOx1Gw55Qgcy57zbTP/thOu3Z38D4gfPTsR2wyTjI6l6sTmzpuxBSYoERHL0LV4qJ7Kq66BlZx8olK6guaOgMiCdOzYWh/E7bCPTNY7JMMafT12jNor12Lix0HuRZN9lVqKcvSFKBFsDeqLGX9BpxoBaQdqr20S2rQXr1PSmZih7yOe7s8Hq7SPHqbNfs8jSpBohsREVP6TrxfNpV0xfJjglqVPewo0IWnrApYRdedfsZHkna90a0i12fYaGmimodOXSJSnNp2Flp6CjmFsi9/dXipcpH6NYQISbXww==
- Cc: Stefano Stabellini <stefano.stabellini@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, <george.dunlap@xxxxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <roger.pau@xxxxxxxxxx>, <Bertrand.Marquis@xxxxxxx>, <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 18:33:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, 27 Jan 2023, Jan Beulich wrote:
> On 26.01.2023 19:54, Stefano Stabellini wrote:
> > Coming back to 18.2: it makes sense for Xen and the scanners today work
> > well with this rule, so I think we are fine.
>
> I disagree.
OK. I'll resend this patch, removing 18.2. I'll mark it appropriately in
the sheet as well.
> Looking back at the sheet, it says "rule already followed by
> the community in most cases" which I assume was based on there being
> only very few violations that are presently reported. Now we've found
> the frame_table[] issue, I'm inclined to say that the statement was put
> there by mistake (due to that oversight).
cppcheck is unable to find violations; we know cppcheck has limitations
and that's OK.
Eclair is excellent and finds violations (including the frame_table[]
issue you mentioned), but currently it doesn't read configs from xen.git
and we cannot run a test to see if adding a couple of deviations for 2
macros removes most of the violations. If we want to use Eclair as a
reference (could be a good idea) then I think we need a better
integration. I'll talk to Roberto and see if we can arrange something
better.
I am writing this with the assumption that if I could show that, as an
example, adding 2 deviations reduces the Eclair violations down to less
than 10, then we could adopt the rule. Do you think that would be
acceptable in your opinion, as a process?
|
