[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/3] xen/arm: Reduce redundant clear root pages when teardown p2m
- To: Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 27 Jan 2023 11:04:23 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr8Ewi+aEYg+FppOqBJ5NN8pgGWxGVq5zqHmAceUmPk=; b=Q6Z4kT0pEdGYeiZFj+oC2BUDZ+FCwj13kpREfQHzPvAQy+xREmJG/1zk7TvIrJef3SCN7X0wzVkOK2tmOjf24UnlEU1rXVTLTY06piPpzvF8BmZ+8eSbIbd/0FjX/6DxBjtkpKntEfL0am84Kj1HNx31FRnTtlJtBmfnlAYeYYBPEv9ltoYXhkdSI5QujqJ5pKFON8GTkRgdnw8Z5pEF53R31e149W89AzJfywnZntZhwLAi19ZFoBkRsbV+GDXb1f3KpQ3Gfy7J0J04Ecs7X1vuoTljLPB19vL6lrhbkGfHYueAlloHjuiGlZpgTan/4XVHzPmFJXNz8IZVV0JbSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uc31rkgnuo2O3lpb1Pun+1StVFCSG3V+6OwwlC0u2w8mYWRah0iqRJZg9w9N/wOOI1xFvtkCGeeDO94BuSHgN6sTb6W7tuCEtFCe59AXQ7S2fZVMB30xzwT/lLDLqKB3GLUI2Y8/gWL3FGfpS9oBkld0jSlddJ5oj/Y+CnBP/cPha5rdHY5Q0eQmb4GQXfewE8yV3fWV5SjxsshG3d6rdqPjizep8MefVL8kWWXaG7xHSZdiQH01T2jhOieCSDp6ThVRXuukRER4D3mnKYUimRjJ2iEx88orxsjf4ERFWehBauD1GwYVHWpuuT5+FNqETJc7BxVtqqgrWElzLZ8XXQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 11:04:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZKU4erKVguEhJ4EOF/N1uL2C1/a6nFMuAgAbbyYCABDoEcA==
- Thread-topic: [PATCH 1/3] xen/arm: Reduce redundant clear root pages when teardown p2m
Hi Michal and Julien,
Apologies for the late response.
> -----Original Message-----
> >> + PROGRESS(p2m_root):
> >> + /*
> >> + * We are about to free the intermediate page-tables, so clear the
> >> + * root to prevent any walk to use them.
> > The comment from here...
> >> + * The domain will not be scheduled anymore, so in theory we
> should
> >> + * not need to flush the TLBs. Do it for safety purpose.
> >> + * Note that all the devices have already been de-assigned. So we
> don't
> >> + * need to flush the IOMMU TLB here.
> >> + */
> > to here does not make a lot of sense in this place and should be moved to
> p2m_clear_root_pages
> > where a user can see the call to p2m_force_tlb_flush_sync.
>
> +1
I will move this code comment block to the place that you suggested in v2.
>
> > Apart from that:
> > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks to both of you. I will keep these two tags with the fix about the above
in-code comment position.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
