[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/x86: public: add TSC defines for cpuid leaf 4
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Krister Johansen <kjlx@xxxxxxxxxxxxxxxxxx>
- Date: Thu, 26 Jan 2023 09:54:51 -0800
- Arc-authentication-results: i=1; rspamd-7b784c8cc8-jzzsr; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@xxxxxxxxxxxxxxxxxx
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1674755694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jxmpzMRS8uv3Rx43UOYjHE4GiOK6D+gngqmat/OvKTQ=; b=AQfgmF5sW+ntihOWQ6Vke+AXGJrE91B+aBonYWQblB5AUrfZY8L8akUZ0Pw+lJCmdfRBTJ p8vga3lXnOGzwGw03UkzEPNrVLJIOp+O4WkKWf+qTxK+JrXGKVddfHIZqanvkbUFwmea2K HVMcPW7PUd/oH/je4vf/3fJGRoSvolRPrtR4KacAzoWHgge0+Sf3MesLtelyf9u7OF6ncx zmtspb9JliiaAgNI8ANi1OQOa3HB0cQN4cbkPAixnIYsIpsDaWN1QqZQoakA2pDLjSMrEB l+FZ4PE+thOL6lFkn9CAAVy2a1lhF0pIu67cYQwVM8NRSERkPEA9ujljTL7jJw==
- Arc-seal: i=1; s=arc-2022; d=mailchannels.net; t=1674755694; a=rsa-sha256; cv=none; b=07rfH9T6IVlT2nXEgcpxUcr7SdvG8EQ5l7bhIi2VZhUCTEP/F8FK+HO7Rq09JATZuigxxG xoSftRnZ7wVHkUwlBmAYx0ooScCJBFTDbCFtHESzPwYHxrqqcfn2Xbk5oo++TkWjcyIE1K /KrWHgxoQ5cwqQiXVnQCUsfYZoCp8WGjhp24CavKyIiRvAQtMhbhRYX/7IMXJJTHOIPPJ3 uXUhnCO+OE8dCiw6JN1p/8T+LjBpxxEjIH8DP5oSruLXta9E5B2pmgph33hIedpEGEB2tY btrwi5URFxYevq49mcJZNkpQeP0k33Mlcg4SYFBQRbi9zyemNrTdygfF7vu9eA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, David Reaver <me@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Jan 2023 17:55:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jan 26, 2023 at 09:57:43AM +0100, Jan Beulich wrote:
> On 25.01.2023 19:45, Krister Johansen wrote:
> > v2:
> > - Fix whitespace between comment and #defines (feedback from Jan Beulich)
>
> Hmm, ...
>
> > --- a/xen/include/public/arch-x86/cpuid.h
> > +++ b/xen/include/public/arch-x86/cpuid.h
> > @@ -72,6 +72,14 @@
> > * Sub-leaf 2: EAX: host tsc frequency in kHz
> > */
> >
> > +#define XEN_CPUID_TSC_EMULATED (1u << 0)
> > +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1)
> > +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2)
> > +#define XEN_CPUID_TSC_MODE_DEFAULT (0)
> > +#define XEN_CPUID_TSC_MODE_EMULATE (1u)
> > +#define XEN_CPUID_TSC_MODE_NOEMULATE (2u)
> > +#define XEN_CPUID_TSC_MODE_NOEMULATE_TSC_AUX (3u)
>
> ... while I'm fine with the leading blank line, what my earlier comment was
> about really are the two separate blocks of #define-s (the flag bits and the
> modes). I'll take care of this while committing; with the adjustment
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Sorry I miunderstood, and thanks for being willing to fix this up
while committing.
-K
|
