[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/helpers: don't log errors when trying to load PVH xenstore-stubdom


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 26 Jan 2023 13:42:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fCIVs0Urt1X0gEKvV55PmOdFxv9nt7cPT5Q15l+hdtw=; b=P6hYdFFCJtRgINdiyMhiLr0VKg2g5G+mRuggH64MRM1vv/wK+7JNp+Yf7B91giV3Yas+uOmX1NQ5eKE4vY7h/PMuhS3JguTBthKM4sg6tI5s1yb2QS4ObmTYpjIuLqAMNopuEBvh4J99aGu9ZKwxOU9UbSLz4rAG49uv/VkiMDt/vKlYI/Hv6B9EtdLzqaPWdaRWjLG4KfDdqApcNQBuIstC5g+imOte7Rm7svC1USytzko45HNmUsHNYUEdp4wjyZP1rJrkJMhWHVr0GrdgJLmRELVyHWIMf13KRV70vW3MOegeQzGUSMSSnf1NfkNd+mo8vb3+3dUBkxs/9vJweQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IuqP638I+4WqBBCP5FB9x/X7qBxV61sHYai4874dCn0Kpy1ZcnuJPz2VwLI6XClc3NdJcREfE8JYxQSGzBqj4cVsWOZhHManMAjxPMUPXD2N9a8TvpgXv3eGXhAIhCFW+VOA9+MohNQvh2GPbNuqQfWM0oZi37sEhE4t4wtgMjhpx6pfbf/9O5glB6x1xKCF16JZ+kQYssSvdHzb6NXGvl3p3NpnkAfk9wGO6xcafgcfOZmidwNqj/Bi1Vd1PnymY3pUYIuSiZQrwDd9MqXtn2c4GHXcQVdmT2mw8mwJZYgs6kbgLl3a5dS0WcDfnWsk+Iao0U1T93GO4pr2VHv47A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 26 Jan 2023 12:43:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.01.2023 13:24, Juergen Gross wrote:
> When loading a Xenstore stubdom the loader doesn't know whether the
> lo be loaded kernel is a PVH or a PV one. So it tries to load it as
> a PVH one first, and if this fails it is loading it as a PV kernel.
> 
> This results in errors being logged in case the stubdom is a PV kernel.
> 
> Suppress those errors by setting the minimum logging level to
> "critical" while trying to load the kernel as PVH.

And if the PV loading also fails and PVH was actually expected, then the
messages will be heavily misleading? Shouldn't you instead accumulate the
PVH messages, and throw them away only in case PV loading actually worked
(or issue them at lower severity, in case they're actually of interest)?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.