[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise

On Wed 25-01-23 00:38:49, Suren Baghdasaryan wrote:
> Replace indirect modifications to vma->vm_flags with calls to modifier
> functions to be able to track flag changes and to keep vma locking
> correctness. Add a BUG_ON check in ksm_madvise() to catch indirect
> vm_flags modification attempts.

Those BUG_ONs scream to much IMHO. KSM is an MM internal code so I
gueess we should be willing to trust it.

> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>
-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise
  - From: Suren Baghdasaryan

References:
- [PATCH v2 0/6] introduce vm_flags modifier functions
  - From: Suren Baghdasaryan
- [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise
  - From: Suren Baghdasaryan

Prev by Date: Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls
Next by Date: Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn
Previous by thread: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise
Next by thread: Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.