[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v4 2/3] xen/drivers: ns16550: Fix the use of simple_strtoul() for extracting u64
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Jan 2023 16:58:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b7d7ZlAm2BxCPrIvK1TvA6JtRrtUwPvml/FrnjP+me0=; b=gA6G6DzCAF3vO85q3Id2T29RKyC+tIU/hbSC5GWrS9KSnulDh4nd8JkRdd0fUecLko819OJRbAi/73EtoMyfY+XqtwELBmvrMYXtTKswV4btrUgAxRnIgUH0O2BC2bR00iCY3pb/9cHibFei6u45uBVzz5JInJCAjH8uj4RrWcUixPjd8mt6Cc1KdQUk1OFU66L4SZdxBnY+bf7ORJf240FtiVP+HgntxLm8O2QOZQkRZ9u7tskV4UwaACXitnlRskciZOWAyD9OBIuGDrCT6zUW/7PtkuebfAHwSFWGAiUCvhZ6R+q/3bOSpPMCuTstGkJBnvRBZZ6WwbMTGb6YIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sdi4oHl07HOxj8Ea0KoXAXtrm/v0J4AscAm+AnLeq7+VrEsO3PrWwDzWJeLO0EC1+Daflos+xxDKNp3+uHnNvWBKl6g6rpeoB0hqrahcBj99X9gsLiFUkGL49b/AmSmUWvYiHI0hx77amBtPQahO516yu6sq2eXLJtm1+86+YD/7ot9A+YCtBIuCUlwfwmx3mguhSbC/y4kJk7JGuC6mun742fxorp27HPPnW9036y2OVnZibMzwyF/ix956xIt4A76fqIEHWB9OckuZfxRdVg5ZKt6VHreqA+pKowZM9IZo+zYUuHyzKf8zoHmnqTVn7SYdb4A9HOPVHWP5rjP+Pw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, wl@xxxxxxx, xuwei5@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Jan 2023 15:58:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.01.2023 13:23, Ayan Kumar Halder wrote:
> One should be using simple_strtoull() ( instead of simple_strtoul() )
> to assign value to 'u64' variable. The reason being u64 can be
> represented by 'unsigned long long' on all the platforms (ie Arm32,
> Arm64 and x86).
>
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
While committing I've taken the liberty to replace "extracting" by
"parsing" in the title.
Jan
|
