[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/14] xen/riscv: add <asm/csr.h> header
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Jan 2023 15:31:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgORcjBjEs4wfTCx6OQAaXyz7uoAGriVI8R68Ni1WsM=; b=WaSjOd2uxY2+QZxgfUBBZrbQnZ8JvqMXRE7YWgFu1f7LFbBFDeykSv3wKTGeKksmKFuhw0PpERO2QZBd82FEim/rB/lTyC85fpb5qqS4zuORnrWLU02pdLYiCfQG/0EVgFeUYObtWaKQqPkeSiP2tDXjQ5RrpHsAWA+yHCv2KlMpDtVb685dI3yJbcM1qzVpjwtqu/i/kYrPmNyvfj0AnNQ4yUp3ACmPu9O/CZUDgWdUQPMgMH3eUeZp751IQFTZW7MSwm3lxSyzjNPMV2IJAOiiizO1p1d59S4Nnr27vCpItNgnpzB1UzqMHMYX2taY1GmUWFX3jaieTRi3Duj8ww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfZWGWLbdCUbNUgE7ZKomIDO+qqb/Rc00xYFyZ+FzMtQ32HlelosJajmB6e7wIUOrwBYEcq3ySFGne9EdKyng0ejgig5apFW/sO8pn53QmbNUcFTMuoOktfSusDRsfDzjKdyG/ZuiKU5flLg52/SrHF+RC8XD+GHGo+yWbxrGpNf9oSmDiE9Mjz7jnxZ+VBO5N2cr6wXhTR2fsoabFN2kz672DIigy7TfbE4LUbiKq2ct1R9fL+qQfx99zNDKDXit+UdKr1W1PVFpLrnr4CtiRL61AEDLR3P7gHMWSSzDi0/EoBWBXvwhrbUgz4s5I9znFmImGBeZx0tGDxaq/YrOQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 Jan 2023 14:31:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.01.2023 15:23, Oleksii wrote:
> On Mon, 2023-01-23 at 14:57 +0100, Jan Beulich wrote:
>> On 20.01.2023 15:59, Oleksii Kurochko wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/riscv/include/asm/csr.h
>>> @@ -0,0 +1,82 @@
>>> +/*
>>> + * Take from Linux.
>>
>> This again means you want an Origin: tag. Whether the comment itself
>> is
>> useful depends on how much customization you expect there to be down
>> the road. But wait - the header here is quite dissimilar from
>> Linux'es,
>> so the description wants to go into further detail. That would then
>> want
>> to include why 5 of the 7 functions are actually commented out at
>> this
>> point.
>>
> I forgot two remove them. They were commented as they aren't used now.
> But probably there is a sense to add them from the start.
>
> I am curious if "Take from Linux" is needed at all?
I said, I was wondering too. The fewer you take from Linux (and the more
you add on top), the less useful such a comment is going to be.
> Should it be described what was removed from the original header [1] ?
In the description, yes (or, if it's very little, simply say that much
more is present there). Doing so in the leading comment in the header
is risking to go stale very quickly.
Jan
|
