[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v2 02/11] xen/arm: Use the correct format specifier
- To: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 20 Jan 2023 15:40:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nSkRRpoOwtmAPbRvNaRj9rkrGYQoBV4WMN4Ek7MbAV8=; b=XqUgdQ2zXZvxJ9PYfpe6gyUgWT8QpsGLJDZ9CYGcDhOIPOZ0idlBHzrWfXNFu39Cx1kSe1Q/Yvp9bZmwhx6lc649PMyy6a8fLolK8/SlVNoWW17KiuWKVMyqcebs6s2Scrqhrp0egmpr99ZNWsrIpRtv8/ulFn6OGw/fCW8kgsS7+s+v95TedYALPXm0StRRk61WZ4np6fz9HnrTsfi0IQxniqftV2o/s3y4f+sq9ZEg7NBM/D0KXpaLP+nJPYEksOioMVg20KDn3IU3uNid6ig2cw4Vjf5rFynF5rKSKIWbDwS6w7Uki1JWByIpn84TOIj/sGB4kcbRiC+ed4jD0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdmQSs4PigCpDhlEGurgvx0aPsunO8pYfJPbSlUmta+D2WxpHeHMvT7ELnrtQ04t2U8CE7hMR2d6gCdavYknpCjM8YpdHTARgEVpsoeOlwFdbEXwzURAIdY06MRTkf6Oh/jdrWpSb6fdCViZHRvjfqr2Oc8tMlBZU2hfL1xnPJOPjqNo0+Dfz2UXLY0C/p2w4WtgGWOcw+sUOO2HF2dXx0TwqKoSsuUNuga6LYGKUsqeUP/BB6H/23EZIEaeexunH0SaxfpawRbPc9kDhO1mF4pnr/pcITAchwFZkY7wP96k80CFSGeSGTJLoI+rTFv0RhA/IPeWwKmjYxx3MA2mCQ==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <stefano.stabellini@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 14:40:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hello,
On 20/01/2023 10:32, Julien Grall wrote:
>
>
> Hi,
>
> On 19/01/2023 22:54, Stefano Stabellini wrote:
>> On Tue, 17 Jan 2023, Ayan Kumar Halder wrote:
>>> 1. One should use 'PRIpaddr' to display 'paddr_t' variables.
>>> 2. One should use 'PRIx64' to display 'u64' in hex format. The current
>>> use of 'PRIpaddr' for printing PTE is buggy as this is not a physical
>>> address.
>>>
>>> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
>
> I have committed the patch.
The CI test jobs (static-mem) failed on this patch:
https://gitlab.com/xen-project/xen/-/pipelines/752911309
I took a look at it and this is because in the test script we
try to find a node whose unit-address does not have leading zeroes.
However, after this patch, we switched to PRIpaddr which is defined as
016lx/016llx and
we end up creating nodes like:
memory@0000000050000000
instead of:
memory@60000000
We could modify the script, but do we really want to create nodes
with leading zeroes? The dt spec does not mention it, although [1]
specifies that the Linux convention is not to have leading zeroes.
[1] https://elinux.org/Device_Tree_Linux
>
> Cheers,
>
> --
> Julien Grall
>
~Michal
|
