[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 20 Jan 2023 14:10:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twFvgIgQ0t0sucpxXPX0REiwICs0MBYEdRKZ5HyJ2cY=; b=c5GelhtO6tdM6RVbulT1XxVMDo1Y7GifM1jFHGFDFWV34IJFd97o5JCEm0uc+B/L+X1bPNQomqLbdCJIFHJ7IGr4s7aGxJ0nO4GVvHHwglPT4UxG8B9RSzkia3hUuAe4zeQn4JIwlIYRyXYidnONUsaMFGWLLdI6SbtoDzyXfzZ0gguQLajpT8csiY6MI668XbFC4dO3PtvQrOuHVjj5lLzLZscgkGw3uHUlTOCoKXTodjehFXI6e2v1hUMyGkEbxEco1GwO8ohauow5paWbOamrc36ed7I4PPAGpcUPXGNj4jECMk3aqAM7JvS2TCwSByFMRWEyKDbYgbPoohtRGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7n1z8eYi/+aWch+JavLwwMv03nPsjf57AOGdbdqOXLGTUtaTvevudja2JPOSlqpZYCQdP4gXPEHs+ialQ2bW4gIP8ocY+rafo4qlR/D7ORtim2Atu6CazHxuyCDpEgOwGLzvE3NnBw97teNrgqzQHuQfKZd9hsrabfbSPdMSXZyyaI5T/0c7lyuoQydBSKcxcfx5em1tLXEMKICgGq3OlatDpI82XILwHv8QuKktZm1vtEa6mkHfYqVReIEvO3FbSBoABM+Qs/uvkTKfhcwC7bgSozV91oPrks8hxL+RjiwYe1Bab9G1GHf5mFcjvUtWnnLTIFMQrSDmAsW8I/LaQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 13:11:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.01.2023 12:45, Andrew Cooper wrote:
> This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated
> on using atomics only (with no regard to what else shares the same cacheline),
> which emits a diagnostic (in debug builds only) without changing any program
> behaviour.
>
> Based on read-only p2m types including logdirty, this diagnostic can be
> tripped by entirely legitimate guest behaviour.
Can it? At the very least shadow doesn't use p2m_ram_logdirty, but "cooks"
log-dirty handling its own way.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with the last sentence above corrected (if need be: removed).
Jan
|
