[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/5] xen/riscv: introduce early_printk basic stuff
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 20 Jan 2023 00:48:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMQR7PAlz2RaPG9+7fc+6IJPDJjCaab4NobvEecYcdI=; b=kk11RCg2p3B92pW5XEV5Bq+3LE5P9W4t9Et3fLqPp8No4Lw9ThpfPcqmbNF1cZIalPIluUMAWRkXUN6birx2kb8Yo4i7PMOikMJXsD2OqW85eEDidE6VDC9W/VbWlaI0FMxD7kbMq/A6b/cw0CHSq9973K+PkjL50B3fSLj5EkRWy00LNQIGSu0CWhpv4C/hLNZ1qxmpjPHN6SsUwH0006EYD61E7i2lPJMLVeDvEclOftRYLGK33wFMu+AF0k5PReMlBXi5EY+QplwhevIILiKyJ4DbRlbcBq5GQlfPb8Vo1r4yazmQeZfCT1SDWFZLrBYBGVX5l2wChwJLp1yGqQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VILW7RbsPFEY7lFUTFpkQNoqm0C7MzmU6nWBWfZfeylURee7NUTeBET5GP4P3SRwTQttef8eK35mpnhGtdRcdfVmX+TxirBnP36HjQUzeM92esJ9y+eer5VhC98dLTGhOZv5NoULNfF4mEYB0MDSNKF2YuX//J9FS2gTQFrPLCyiou5i1lVaMT+XkXXKzGQt7PDAzf5LMWGZa2p8gBjY+duJNIPU7Jty+ESzTBcDlHjBKMM0AUY6zK2eaHs3w1FrgmxFIG3oAxiSr/5c7JTTXstLZtvbl7S7gbrNfSTdGMxtrOY3CUP5/CRgdK7qd0/YRX4qFJZvOk+pyc4Qo5k2mA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 00:48:54 +0000
- Ironport-data: A9a23:1xXmkKJGSaoKc9l1FE+RjpUlxSXFcZb7ZxGr2PjKsXjdYENSgjwGx 2YaWDvSP/aPMGr8Ko9zaouwoUMGuZKAztQyQVZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5wVvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pW1FT2 OAiOAoSNAqhhvLonK+/cvlj05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMkWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHinB99KTu3QGvhCx0zM/FMpLk0sSELn/PjnmGW4Sv1EJ BlBksYphe1onKCxdfH6WxC7u3+F+B0BQd1bE+49wA6Iw6vQpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRuwMyUIKW4JZQcfUBAIpdLkpekbjA/LT9tlOL64iJvyAz6Y6 yuRsCE0irEXjMgK/6a251bKh3SrvJehZgE07wPTQ2msxhl4eom+Zoqjr1Pc6J5oJoGTREiMp 3gAls2X6sgBCJiMkGqGR+BlNLit5u2ZOTzGx1B1Fp8q9i+F5HKoO4tX5VlWL0BvNMEGdTb3Y VT7tgZY5ZsVN3yvBYd9ZIi7GoIn1qjkGNHsUNjba9NPZt56cwrvwc11TUuZ3mSonE1yl6g6Y M6faZz1UitcDrl7xj2rQetbyaUs2i012WLUQ9b80gij1r2dInWSTN/pLWezUwzw14vcyC29z jqVH5LiJ8l3OAEmXhTqzA==
- Ironport-hdrordr: A9a23:v5h6XKybNEcKTBadnEYXKrPxx+gkLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9IYgBepTiBUJPwJE80hqQFn7X5XI3SEzUO3VHDEGgM1/qY/9SNIVycygd979 YYT0E6MqyNMbEYt7e13ODbKadb/DDvysnB7oq+r0uFDzsaFp2IhD0JbjpzZ3cGIjWucqBJc6 Z0iPA3xQaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJppmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF4CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA/7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1bwKoVKuZFIMvJ0vFgLA BcNrCE2B+QSyLDU5nthBgp/DVrZAVpIv7JeDlZhiXf6UkmoJkw9Tpp+CVYpAZCyHtHceg928 30dp1ykrdAV8kXar84KtsgbKKMezHwaCOJCXmVJ1v/EqEBJjbqkL7YpJsIxMzCQu1V8HMV8K 6xDm+wcVRCJH4HBaC1re522wGIT2OnUTv3zMZCo5B/p73nXbLudTaOUVY0jqKb0r8iK9yeWe 26N49WD//lPi/pBZtD2RH4VvBpWA4jueAuy54Gsmi104n2A5yvsvaefOfYJbLrHzphUmTjAm EbVDy2IMlb9EikVnLxnRCUAhrWCwDC1IM1FLKf8/kYyYALOIEJug8JiU6h7sXOLTFZqKQ5cE Z3PbuimKKmomu9+3rO8gxSS1dgJ1cQ5K+lX2JBpAcMPU+xebEfu8+HcWQXx3eDLg8XdbKeLO eenSUAxUuaFe3l+cl5MaPUDouztQpnmE63
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZLA9l20cepYD69E6g31XDw2HHwK6mebiA
- Thread-topic: [PATCH v5 4/5] xen/riscv: introduce early_printk basic stuff
On 19/01/2023 2:07 pm, Oleksii Kurochko wrote:
> diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c
> new file mode 100644
> index 0000000000..6f590e712b
> --- /dev/null
> +++ b/xen/arch/riscv/early_printk.c
> @@ -0,0 +1,45 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * RISC-V early printk using SBI
> + *
> + * Copyright (C) 2021 Bobby Eshleman <bobbyeshleman@xxxxxxxxx>
> + */
> +#include <asm/early_printk.h>
> +#include <asm/sbi.h>
> +
> +/*
> + * early_*() can be called from head.S with MMU-off.
> + *
> + * The following requiremets should be honoured for early_*() to
> + * work correctly:
> + * It should use PC-relative addressing for accessing symbols.
> + * To achieve that GCC cmodel=medany should be used.
> + */
> +#ifndef __riscv_cmodel_medany
> +#error "early_*() can be called from head.S with MMU-off"
> +#endif
This comment is false, and the check is bogus.
It needs deleting.
~Andrew
|
