[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 17 Jan 2023 08:29:48 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obxlW2dDYeA7ayaxyUNGp6UxsW1h2hrE6LY/khFLDFY=; b=iJjBxNg7JNyKCTG79BqiA/cO4OSlDzSZJzKcozipqOSElR1FsIqnjkhq8EHQAse/Pg0PmdMYQqvi7/k7LzRqXuwrJKA5VCbyLOiLzYTWkrBZ9p/NqucLb/ZyqeB54j7v2zrvg9gd6pF5JtaEFsZclwleoKM+18GJ0IMjpazaqUl05pD3Kt/S2olmJLyKzObXTJYTmU4VyikGpfsSol2ad5q1KqOCfyfuJOox2NQx0wAYE55RwKQNAOyLgfQlEYbZpaVi+6SJ+tX7qqu655pXHGGzmtc9lgfDBmOyLnv1Tt2nr2vrNjOmxMhny81BiLawnifFA7evLAJq0mn+5XQdyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofkaBzaRw9OEP+a21wmn61fPleztMMS6lygblzmaaRsegfTKT/4Q4TZNOTDJ16xXrI9mMMO+NVV56Qi/4x5ML3gB4Q8cnMxZxQAvcz0D2gMVZIssiZ9xGdYiH1jlf+YZZkLGDZ81sChRIbcv+apt2jtSDoS9ALw5crWeJejGIqAH/W68cQmIYEqI7JBZ0o/y7a42De3ynrB/CDNxwkrYKhOsTAIOuazIzpnA4GHDD8kPuffP3Jp/K61xZp19cbFiaKGtHNCwpPf5HNRA3Fnda6Ar2d53Iik1ZcEhYh++KLQwfQymirT/ipJlCYe7nKCS7gnS2YYflUsJDZrs9ZDqhA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 17 Jan 2023 08:30:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZKbkuhF2CydVKlkSWMcq+jFNCca6h0FvQgAB02YCAAABNQIAAAoXw
- Thread-topic: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation
Hi Michal,
> -----Original Message-----
> Subject: RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation
> > >> -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256))
> > >> +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (266 - 256))
> > >
> > > From the commit message "L0 slots from 256 to 265 (i.e. 10 slots)", I
> > > think
> > > the actual range is [256, 265] so probably using "(265 - 256 + 1)" here
> > > is a
> > > bit better? It seems to me that the number 266 looks like a magic number
> > > because 266 is not in the range. But this is my personal taste though and
> > > I
> > > am open to discussion if you or maintainers have other opinions.
> >
> > I think this is a matter of taste.
>
> Yes indeed, so I wouldn't argue for your explanation...
Sorry I mean argue against here... :)
Kind regards,
Henry
|
