[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 12 Jan 2023 12:31:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzJ8GnLtgQgzREvZeQzHoLZ4aqo9Q7Nx3aQJCiyMG5o=; b=Vd0Pk4gpqU4IQcjsv3JGdfKZBt+mvG06AE2xSN6xBwxI7VomPzynAzOWu/8P7plTcdTvcfMtr0UIFYj8sswKIoFs+piWwCLJ00HVEJTVA9jc64obySV53WgU/9djvRvIc+QES+Dt6tHJrjBc4L99GHBQ66mN1EEQPkE+L9dD8LTzrYs9L36Sw6sGjQKA8odKV+70RAcu4ipqZ+9BPn3gxOgLRC2RPSzL/vXB1t5yOLTFOoorz/uBoeoXEaySwVFxYmNCtCWw6fG8Pd6nQgq/6iWLKUvT57WMkyDRIjE1hO7rPLUJMi0MSJSsRcEIpVmv2PlL5wwObiJVGhaaI7oF2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZjvuQn+kyTQ9VHkz1bASGQ98kxRESvVFRsyTm5IdVYW1Ns/IHF6HJ0huUB7RmJXfcSktVW0eoVxpYt4qOWwp9gSAySjpyWdz6eqih+DEfFnCjT2rDpJ++WddyOuCeGjzzkvFJHBGrAM2vDUN/VhVcLg8lKAsEzD07BcOWw/y0rq1A8nTq2/URWy+PuP+LmicAiKYXEeZsxDqQwR0O7I2oeqfnL92JChgb+VLhnsJQ34KC6R5PASQ1t9Q0SQLatBYVcMAoRzGPwR0NWM2Izhczr2RFJe8luxYGkBG+Yqj2D9fSNpyWb5CDXer9iUTb1qFp3eIW+ipMWxp0Gji7SGfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 12 Jan 2023 11:31:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.01.2023 09:44, Xenia Ragiadakou wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -82,11 +82,13 @@ static int __init cf_check parse_iommu_param(const char
> *s)
> else if ( ss == s + 23 && !strncmp(s, "quarantine=scratch-page", 23)
> )
> iommu_quarantine = IOMMU_quarantine_scratch_page;
> #endif
> -#ifdef CONFIG_X86
> +#ifdef CONFIG_INTEL_IOMMU
> else if ( (val = parse_boolean("igfx", s, ss)) >= 0 )
> iommu_igfx = val;
> else if ( (val = parse_boolean("qinval", s, ss)) >= 0 )
> iommu_qinval = val;
> +#endif
You want to use no_config_param() here as well then.
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap {
> iommu_intremap_restricted,
> iommu_intremap_full,
> } iommu_intremap;
> -extern bool iommu_igfx, iommu_qinval, iommu_snoop;
> #else
> # define iommu_intremap false
> +#endif
> +
> +#ifdef CONFIG_INTEL_IOMMU
> +extern bool iommu_igfx, iommu_qinval, iommu_snoop;
> +#else
> # define iommu_snoop false
> #endif
Do these declarations really need touching? In patch 2 you didn't move
amd_iommu_perdev_intremap's either.
Jan
|
