[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include/compat: produce stubs for headers not otherwise generated
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 12 Jan 2023 10:18:17 +0000
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 12 Jan 2023 10:18:46 +0000
- Ironport-data: A9a23:lxnaMaDZ1mP2ghVW/xTjw5YqxClBgxIJ4kV8jS/XYbTApDgi1jAEx jBJUW2DOviNM2qmLd0ladzj/E4Pv8fWyNZlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpB5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2/srBWFM9 8IjcDkDbj24pMbm0e6aRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKEJoPWG54Mzy50o EqW7jrEWE0mHeeOyCegy0iB3e/muT7CDdd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/JPF8Uq5QfLzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3 gxmsgAfmukXjcwJ6Z7j9F7HrgmPgsjYEi86s1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZ9CIUvIT46NuhXogj1mPPBMmPevpn0GWKJp9zmFfLIQua8+I 4yHVs2nEGwXD69qpBLvGbhGiuB2mHBjmj2DLXwe8/hA+ePADEN5tJ9faAfeBgzHxP7sTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBiba0aX/d/L7bZSiI/QTFJNhMk6e95E2CTt/gPx7igE 7DUchMw9WcTclWceVXaMCA7M+K/NXu9xFpiVRER0Z+T8yBLSe6SAG03LfPboZFPGDRf8MNJ
- Ironport-hdrordr: A9a23:vtQgsKupwSSo291kJDBBN5Zc7skDcNV00zEX/kB9WHVpm62j5q aTdZEgviMc5wx/ZJhNo7690cq7MBDhHPxOgLX5VI3KNGOK1FdASrsSj7cKqAeBJ8SRzJ846Y 5QN4R4Fd3sHRxboK/BkW6F+g8bsby6zJw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jan 12, 2023 at 10:17:47AM +0100, Jan Beulich wrote:
> Public headers can include other public headers. Such interdependencies
> are retained in their compat counterparts. Since some compat headers are
> generated only in certain configurations, the referenced headers still
> need to exist. The lack thereof was observed with hvm/hvm_op.h needing
> trace.h, where generation of the latter depends on TRACEBUFFER=y. Make
> empty stubs in such cases (as generating the extra headers is relatively
> slow and hence better to avoid). Changes to .config and incrementally
> (re-)building is covered by the respective .*.cmd then no longer
> matching the command to be used, resulting in the necessary re-creation
> of the (possibly stub) header.
>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
This patch also takes care of "removing" compat headers that are no
longer needed due to change in .config, which is good to have (even if
this only remove the content in it).
Thanks,
--
Anthony PERARD
|
