[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] x86/shadow: drop a few uses of mfn_valid()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 12 Jan 2023 00:05:22 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IWEE+Uk224L1EzdZRWsnZkazNqZOt00zjoy/L5ND+Ss=; b=ONETdCYH/zQzQVeuYuYR0MmHq+t6FqCFmBPwiJKhxNfwelsWMz9SoQk1Gmgtyn4qJ5ky8qqBTyWeC0jj4pJqx+7icfHb6Br9myEzDsnItJ+Cba8JF2wPUk2ZfHMnjDLS2g8V+QTncEowxisZxqXJvBf2jPSVXuVE7amUJiEBtvF5ql6257wyWGSE9ZdLgm2xUVoEHCxwQd751E8Rf0h9KLbDS+8G0/DLddbMvOIM7QVkhuQ/ADeVYSRJbLXGXnnSy81KEyNA490XXCLM7T1AjrENT3WYqNwdGAbG+LSioCRx8m6X1M349YDTauYEFSp/w6KgMNPeBrc57/TJGUlTPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGgQcJhdVDR5De9i6kLVEzsqntOxozNEr6LuwcT7z7cWNNkRxkW9U+Ge4SRoz0bLLGcjOvFk6+RecfMuqrmuq9tUJQBdqCef9oTUeZTbxNB7zTbZhwIy2IALS/RFPHhdrJJWimq9t3ivIxJeACFD7aFESnt0ue7zeXK6QuJu00n0DfXy4zGzUD/4gQGBsMmopzcbyDotXzg1kRgLwDzbdut6MvUaFFhuSaQYn19QMF5S4gTUjvT8LuOQ9GDtDt3Fg+T1SaVqv56AmyZg2rtGzgKn8jnYnM6/1ZZ1dICZWuj85jsXv3MacmstvX9kQZBA0KJKAM8Lb0iUeI8aj94NZQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Thu, 12 Jan 2023 00:05:33 +0000
- Ironport-data: A9a23:VqW9x6txAoi4ss8uU65vrW5c5OfnVGZfMUV32f8akzHdYApBsoF/q tZmKTzVaPbZamL9LdFzaY/n9R8FvMPQzoBkTgA/rnpjQnsU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaHziFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOS0rQ069vPCN8JWHT7Fv2ZQ8LM/xI9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzirKY63A3KroAVIEYZCHSy8PaJtm23C+NAc EkYpW0tq7dnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsUQoAy8nupsc0lB2nczp4OKu8j9mwEzegx TmP9XE6n+9K055N0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlXZX1RvERhmNkwIYw=
- Ironport-hdrordr: A9a23:ANkL4akOm9tAPXhKeALAYv2MOuvpDfIk3DAbv31ZSRFFG/Fw9v re/sjzsCWftN9/YgBGpTntAsm9qBDnhPtICPcqTNOftHGPghrKEGgK1+KLqFCNdBEWndQ96U 4PScZD4RnLfD5Hsfo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZJcQqh5dhxv4yjUqRQKHvfuBGaa6Z55gA
- Thread-topic: [PATCH v2 4/9] x86/shadow: drop a few uses of mfn_valid()
On 11/01/2023 1:53 pm, Jan Beulich wrote:
> v->arch.paging.shadow.shadow_table[], v->arch.paging.shadow.oos[],
> v->arch.paging.shadow.oos_{snapshot[],fixup[].smfn[]} as well as the
> hash table are all only ever written with valid MFNs or INVALID_MFN.
> Avoid the somewhat expensive mfn_valid() when checking MFNs coming from
> these arrays.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Technically I acked this in v1 because the comment wasn't a code
comment, but Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
nevertheless
|
