[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 11 Jan 2023 08:37:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhz+97kEQewXrQMY8ev7cqCU+oOfgrtlWTWgYUbkSVk=; b=NYMN3PBk+1+retThxrA3rEPbAmqABTWtctjgGAYXMBKHBiICdnAOf9+5iC35svKuAX8bkpTLRt8lOnXibbGqxqIvIlpVQNrW6Gl32IVpGYi7UnCvH5BhKlLaz1lyzqDefHZYHEeIqlwOiYx9lGh1QlXg2eSfvkIdFrc/9LqbJ4MPupRrmITV1vmsY0cel0lXHFVTQhJF7CLqkGHVZk24p4L84V6F52bh3zhgPcNChxqs/4OCdifUnr9C2hoE0YSjRjwOhGhwZu3478ZU/UPNWcU+32iOo7AhBlDq6ADlPvfZ1BuHfAUPKZGsEs5F+a8PohP1ZpNYx7lyYE0+Et27QA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ylhaq2dbWYtp2PCsAqbi6EZUATIrgXI3NU9ug2iNoHC01ScMdqf+JG+GmH9b2FXwFSYuWLoNHbTodEFHoy2pZNG63ubP8pfC2nGi9g2U7rGAflQ3WCpfMSRWVxxfDANmEI4eFtnyzYOo1YNlZzpCZWiHPlI9Qt2XGaLfPBtQCGu7iGF9frXU0PHjddpF7A0nrsWo9/A8Z8QHMg3D8XVmUlVf/nLP9nGTTth/WMofU4yZgwYF8Ubs6hSPNaHZO93xR/fpsPUWWizTaohzW4/4Uf/jpjpkTfeI4rO4EFQWh7ynr9GW0NNV2uE/Ic+BfPao00OQ6On9ZNJ9FTPvcwUE0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Wed, 11 Jan 2023 07:38:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.01.2023 20:16, Oleksii wrote:
> Sorry for breaking into the conversation.
That's perfectly fine; no need to be sorry.
> On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote:
>> Arm maintainers,
>>
>> On 10.01.2023 16:17, Oleksii Kurochko wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/riscv/include/asm/init.h
>>> @@ -0,0 +1,12 @@
>>> +#ifndef _XEN_ASM_INIT_H
>>> +#define _XEN_ASM_INIT_H
>>> +
>>> +#endif /* _XEN_ASM_INIT_H */
>>
>> instead of having RISC-V introduce an empty stub matching what x86
>> has,
> Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic
> early_printk and smoke test implementation) of Andrew:
> https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4fdc@xxxxxxxxxx/#t
>
> I agree with his point regarding the usage of __has_include() to not
> produce empty headers stubs for RISCV and for future architectures too.
Sure, but as he said, that requires settling on a new toolchain baseline,
which is something that we've failed to come to any results for, for a
considerable number of years. Plus if we could get rid of this (then
optional) arch header altogether, it would imo be even better.
Jan
|
