[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 9 Jan 2023 17:00:16 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qkg86uDjDm9pfxdD297SKw77Vr9JODE/mSN58hBFiZk=; b=DuLECOgZT7Sq26TqfS32tedJIy/0AJYaA5ltkclBGjQuXgrChVymGl94E2hINFfr/QOA+TFcO2eyAO1asCH6sAmCr6b4YJg4s8R5+sGoB1F+p8t1L1FhDCt0qEWWo+wIEtcXY1C8UHFnawIFymFySYC39DGZSA26ifv3dP/Pk2rxma9ll6J1YFOSDOFBapMJ/VtDZipUpAFdX63tTCakIoL4DUzqvyleO5vLDebgOCe9mZN+ke5xzoEMIMGrIwkEIDu8ZyzGpmBDs9w/+hUm+ot//mT/w/UCTobbPuQ1krxkjOXgDKmCaB4kN1g+gwE3gLfIIxIGPbGp/9e5q253LQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f51LNE/+/DbmVlACFhsNpjEqZxev6I+1p86RVwLGorIztBLPtx9Rc7y54LOa3OvqQDdDpCpFZaJC9Axlqgidbu1r7HAelbvuWFEEuK249jjA/vrMLoi1MrI5iueSTTU6sHCNBJPvg1zZasPC+/Z2kwQ6xO3tPEvP24UV7xQM+ptI5M4EAkyT1rO5bUfo5C7V9TwgAD5YveAXZxwfhUBbK8c0Zt9/7det4Dib8Rn26XsSex7XG55d/Qqs7OLvCMZMmjJaAHQ2OytwqHRZSVMlT9zid6jr+IpZCM68zpesX3TNfJjNapufW5RoLjo/dbTnrhtpLzA4cADkBAvLio14GQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 09 Jan 2023 16:00:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.01.2023 16:46, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/arch/riscv/include/asm/sbi.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: (GPL-2.0-or-later) */
> +/*
> + * Copyright (c) 2021 Vates SAS.
> + *
> + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@xxxxxxxxx).
> + *
> + * Taken/modified from Xvisor project with the following copyright:
> + *
> + * Copyright (c) 2019 Western Digital Corporation or its affiliates.
> + */
> +
> +#ifndef __CPU_SBI_H__
> +#define __CPU_SBI_H__
Didn't you mean to change this?
> +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1
> +
> +struct sbiret {
> + long error;
> + long value;
> +};
> +
> +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long
> arg0,
> + unsigned long arg1, unsigned long arg2,
> + unsigned long arg3, unsigned long arg4,
> + unsigned long arg5);
Please get indentation right here as well as for the definition. Possible
forms are
struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
unsigned long arg0, unsigned long arg1,
unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5);
or
struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
unsigned long arg0, unsigned long arg1,
unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5);
Jan
|
