Re: [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address

[Julien Grall <julien@xxxxxxx>]

Hi Penny,

On 15/11/2022 02:52, Penny Zheng wrote:
> When host address is not provided in "xen,shared-mem", we let Xen
> automatically allocate requested static shared memory from heap, and it
> stands good chance of having multiple host memory banks allocated for the
> requested static shared memory as a result. Therefore current membank is not
> going to cover it.
>
> This commit introduces a new field "mem" to cover both scenarios.
> "struct membank" is used when host address is provided, whereas
> "struct meminfo" shall be used when host address not provided.
From this patch, it is not clear to me how a user can know which part 
of the union should be used.
However... I am not entirely sure why you need to create a union because 
in your new structure you can fit one bank.
Cheers,

--
Julien Grall