[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen
- To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 5 Jan 2023 15:48:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GtOP1m3e6y8lukYciiLXnlei1xaVG5tNYJ7a1NRQhcs=; b=a92T8A40IUUpJtN6helnwLbzKwD2485aLZ0IUJjOEbJqyizu4/IOOcRr/e6Wju52pniqyeF5Af7TR73Lqv44025i/PCiQCEYW3Z3/Z24Z4oUalctAEZJ5NNcllxxMwuei1tzlm42bwnyCL7Ubt8FGK+UyCVzbqzSacbCAA9IAij8uh+W3F/a5IzzFbFhsGIpXY5EgKvg+E6ST7jDp9ZStSUDz3gjlxRRO+v5Y5NggdnLXp4gaGz+AIUb3XffzecR8tu05d+Zy16ggO/YpCmEhzVOboRFlJRgryd77OpLb41sBRESU+c7PMzVTsfRXHgy8MqTvpg3g1FrJwjbZnTeRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2AjWK/FjdCHkKTHc70MNpqmIi2UqLLDrkZEdJ4XcPqDa+szk4tZr+I0mBwQeR9XXtLWuA6FTxcxTPHQsY8LVUKsXfU6W8TQS5urNBMVW8qkxUgYy9ubbiSUoizK+jVRoGCGCPsRIpbGDc7ULKPgsi5Inj8fHYs+XPJTo74EyX/NWcSqGhJzPHYPMwiC47lgwwijq475S93zQuGWI1yrtM0KAomBhT7aSiidpwcXWHKkEsx/ow1FzIv1Oz76Yt+qvt3HTlGbV1n1K2PHM80chghrNB6dTel7Z55T2yGgUqWXoGxVL7TUZeb1pQXjzine4qsUaSx8oxPl35ct31m64Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Jan 2023 15:49:12 +0000
- Ironport-data: A9a23:NvkHKKs+XvokwBFsJQ1dQyto1ufnVBNeMUV32f8akzHdYApBsoF/q tZmKWDQOKmIZ2T0f4gnPN6w9ExXsZbQnd5hHgBqrn00ESgb+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGyiFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCDkrTA+JmOKK352KQdFPncoDDsziBdZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4G9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgrK4y3QLOroAVIB05VEHjk+S0tlS/a8xCE 3MI5zgzsqdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLm8AQz1aad1gt9IsQjcq1 VihkNbgBDgpu7qQIVqX8b2evD6pOSwYKGYETSABRAoBpdLkpekbhxbOVcpqEbTzgMf8Hzrx2 BiVoCN4jLIW5eYA0KO9+lLLiiytvbDGSwc04kPcWWfNxgFkYI+oYaS45F6d6uxPRK6CVUWIt nUAn8mY7cgNAIuLmSjLR/8CdJmm5v+DNCDXiHZ1Hocm7DWr8DioeoU4yCFzIgJlP9gJfRftY VTPokVB6ZlLJnyoYKRrJYWrBKwXIbPIEN3kUrXfaYNIa50oLQufpngxPgiXwnznl1UqnecnI 5CHfM2wDHEcT6N60D6xQORb2rgurswj+V7uqVnA50zP+dKjiLS9E9/p7HPmgjgF0Z65
- Ironport-hdrordr: A9a23:3gm+3a6Q8E7sU8+CewPXwMHXdLJyesId70hD6qkRc203TiX8ra qTdZsguCMc5Ax8ZJhCo7C90cu7L080nKQdieIs1N+ZLWzbUQCTTb2Kg7GM/9WqcxeOktK0v8 1bAspDNOE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZIP2Dn/VS+v8CxEaK8nfj7fmLt66P1KmAgAAjsIA=
- Thread-topic: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen
On 05/01/2023 1:40 pm, Jan Beulich wrote:
> On 05.01.2023 13:01, Oleksii Kurochko wrote:
>> To run in debug mode should be done the following instructions:
>> $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \
>> -kernel xen/xen -s -S
>> # In separate terminal:
>> $ riscv64-buildroot-linux-gnu-gdb
>> $ target remote :1234
>> $ add-symbol-file <xen_src>/xen/xen-syms 0x80200000
>> $ hb *0x80200000
>> $ c # it should stop at instruction j 0x80200000 <start>
> This suggests to me that Xen is meant to run at VA 0x80200000, whereas ...
>
>> --- a/xen/arch/riscv/include/asm/config.h
>> +++ b/xen/arch/riscv/include/asm/config.h
>> @@ -1,6 +1,9 @@
>> #ifndef __RISCV_CONFIG_H__
>> #define __RISCV_CONFIG_H__
>>
>> +#include <xen/const.h>
>> +#include <xen/page-size.h>
>> +
>> #if defined(CONFIG_RISCV_64)
>> # define LONG_BYTEORDER 3
>> # define ELFSIZE 64
>> @@ -28,7 +31,7 @@
>>
>> /* Linkage for RISCV */
>> #ifdef __ASSEMBLY__
>> -#define ALIGN .align 2
>> +#define ALIGN .align 4
>>
>> #define ENTRY(name) \
>> .globl name; \
>> @@ -36,6 +39,10 @@
>> name:
>> #endif
>>
>> +#define XEN_VIRT_START _AT(UL, 0x00200000)
> ... here you specify a much lower address (and to be honest even 0x80200000
> looks pretty low to me for 64-bit, and perhaps even for 32-bit). Could you
> clarify what the plans here are? Maybe this is merely a temporary thing,
> but not called out as such?
It's stale from v1 which had:
#define XEN_VIRT_START 0x80200000
But honestly, I don't think the qemu details in the commit message are
useful. This series is just about making "make build" work.
The next series (being worked on, but not posted yet) is only a few
patches and gets a full Gitlab CI smoke test, at which point the smoke
test shell script is the reference for how to invoke qemu.
I'm happy to R-by this series and drop that part of the commit message
on commit.
~Andrew
|
