[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 4 Jan 2023 01:27:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsMEGptc43vLte0q02CVPOWS3aRKtCm8JX6gPknmLfM=; b=d4NcYJ1Hx+x+MPF00zboJ5BT6tR6jSa7iwWa59ImHY9QS9aYOQl1Up0vg+TMWrkcztfI+TGSoCYRLgJ8k/huVUxzM36yOivM4dCpvMzJFQu32zzvjdUnZrL7ogDpCVK+VAhvEDrbpqHLJexJJRJvJqWBl0MwUxqDrkdQZvbUSq0fhcy0YQVS/rBiEj1CT/CvrbVVtr9r88pi37InZFV++M0q73YUI871TcxI/OnLn95F5kxKkhXdkaDzyn92vuwDJIOSBfLMEqzF13Gz6EqA9jUQc+cSozYReDbAqAa4EYrxLvbt0rUUOj0Co/Gd3K6lfekWZYXW89zYxavQWcb03A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j35cgxW88//7tu9zUnPYnw89O5WIBjTRF+Fw+9EjwbmzmERUsEI38jxJRsP+GkdbAKprYk4xkvc6YR93XpduvgkSgTCiV0BRn+JpZMri2CwcV6F8kD+3AZ/A/NQWXFwpn0JVnoryYFRpTfTz3yylz2jmclOhqS7zKMKTPF4w6S8IsEM5WUI9m/MeZNFpq/m+7UP5RWWS/UcOYVwf0N6JZLhwKRJ8Jymay+iix4Tv8JpXae717T9QkSxERlw7WPmnMUbtfKzsFumvFg4fOlaOvkbJSGc5+wYjmd0wenutgaWYzW1fBRAE3MulNuwJzTzoqONLJ7icDxs66yh1xM2Plg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 04 Jan 2023 01:27:22 +0000
- Ironport-data: A9a23:rfnMHKp/nnagpfBlVQIOqt3YA8teBmL4ZBIvgKrLsJaIsI4StFCzt garIBmGPf2NN2DxeY1zPdnioBkB7J7cx4A1SQdl/yoyESND9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyJNUfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACAcb0+8luXs+7iyTsJ8u+A4PuLgJrpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWNEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr6I13Q3NnwT/DjVLBFeRiOS4sXePWvx2I m491hoIrqktoRnDot7VGkfQTGS/lgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9JmYYaSgJZQAM+dXkrcc4iRenZtNiG668ipvyAyP9x xiDqSR4jLIW5eYM06i45lHGxTGxvJ/CTg0yzgrSV2OhqAh+YeaYi5eA7FHa6bNMKdifR1zY5 nwcwZHBtKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK
- Ironport-hdrordr: A9a23:JwGQCa/ozJNLz6UEVFtuk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZG+cbFLjU6ViRqEqaO8BfTNldnq6NfEWAgAADPYA=
- Thread-topic: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml
On 04/01/2023 1:15 am, Stefano Stabellini wrote:
> On Fri, 30 Dec 2022, Andrew Cooper wrote:
>
>> Whether to build only Xen, or everything, is a property of container,
>> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH.
>>
>> Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-*
>> testcases at the point that arm32 get matched with a container that can only
>> build Xen.
>>
>> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Doug Goldstein <cardoe@xxxxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> CC: Michal Orzel <michal.orzel@xxxxxxx>
>> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> ---
>> automation/gitlab-ci/build.yaml | 2 ++
>> automation/scripts/build | 11 ++++-------
>> 2 files changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/automation/gitlab-ci/build.yaml
>> b/automation/gitlab-ci/build.yaml
>> index 93d9ff69a9f2..e6a9357de3ef 100644
>> --- a/automation/gitlab-ci/build.yaml
>> +++ b/automation/gitlab-ci/build.yaml
>> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32:
>> extends: .gcc-arm32-cross-build
>> variables:
>> CONTAINER: debian:unstable-arm32-gcc
>> + HYPERVISOR_ONLY: y
>>
>> debian-unstable-gcc-arm32-debug:
>> extends: .gcc-arm32-cross-build-debug
>> variables:
>> CONTAINER: debian:unstable-arm32-gcc
>> + HYPERVISOR_ONLY: y
> can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ?
Not really - that's the point I'm trying to make in the commit message.
> I think that makes the most sense because .arm32-cross-build-tmpl is the
> one setting XEN_TARGET_ARCH and also the x86_64 tag.
It's not about x86_64; its about the container.
Whether we can build just Xen, or everything, solely depends on the
contents in debian:unstable-arm32-gcc
If we wanted to, we could update unstable-arm32-gcc's dockerfile to
install the arm32 cross user libs, and drop this HYPERVISOR_ONLY
restriction.
~Andrew
|