[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Tue, 3 Jan 2023 12:15:40 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJNCStJYDmn1oZ0E2+wobE6P7eaHGzm9mLkM3k1B11Q=; b=ffEGqKXZf9/kZ1vYJCYBrVsDq1kiF7yH0ZfoDwOecgS++dBwylOc1rYr6gN3OJ1tjU6KUEN6rFYDHcNn4QkAGBnKsOT/dDvHyWY6piNSn/l5jy3Ss+8e+G9LG19/r6pu0MnPHqfO0gVtTi33Qze7OTIodrjIskA1N/qZLn22YnCOknHt4mtHcHeyAOMfzS+Sp6Wmb/hy4nR4vDapJH5HLUGZnkVR+hv0JQnkSVfPERbk9HNUKGVViCye4IFYfIMRZD8NnyKt12EDKqf31AFu1fKlCf/BL640FvuTTLlX7HBoYFGscGcCaaqeZ0OZ+2TGpNfWZvUfTDajSN5uwPHrUw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzTWRdHDNEkRNFp21ZBe0/CrTV3OnUHeiUI9GI6/E5Va7bmb9i1wSXznr0Mt0+tL5CTANP0pLt10rzywCVdPXdA1pkb60DtCn4Ev0hOrJ5QDvzwekihtgP6I9v+1Tyrn/30ZdYzTvmY4y5kS8rEQ9tC+rgCJHJB78cVBGoAK39pMG4tjDnuMZ776k+litqQDsGLrg5rHvPdA1GgJGBV0zVI8FsrWRwJowfmFjiWXrUzOQtd8FNbOByXKTpLUDJ5G4F0cCAdpE0GyQXFyia8L7cR6x4x8gzbwN1xVsFMO7zzvuQdpDeiLKFgJfYern5wkiftGEDM8YchAJsSMYAqzRQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Delivery-date: Tue, 03 Jan 2023 12:15:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 03/01/2023 10:25, Michal Orzel wrote:
Printing memory size in hex without 0x prefix can be misleading, so
add it. Also, take the opportunity to adhere to 80 chars line length
limit by moving the printk arguments to the next line.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes in v2:
  - was: "Print memory size in decimal in construct_domU"
  - stick to hex but add a 0x prefix
  - adhere to 80 chars line length limit
---
  xen/arch/arm/domain_build.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 829cea8de84f..f35f4d24569c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3774,7 +3774,8 @@ static int __init construct_domU(struct domain *d,
      if ( rc != 0 )
          return rc;
- printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem);
+    printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n",
+           d->max_vcpus, mem);
kinfo.vpl011 = dt_property_read_bool(node, "vpl011");



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.