[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 3 Jan 2023 11:17:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=loQ1+D7roScKs3lPYDTnaMxLHTA/ehvWJiM110hZ2Zo=; b=VhG6bOkBmFYHGpm7nceKkNGJd7nht7Ta2Iogu3PB25TH57tNPvZcfY/OTKzTq5SAiyVZ66Q2IOSS/JfIPA8p98Ogju2peMD5mW03KsLqi9kDCZHpqSAUvTjogWzPnYIUsDCj9hR7OxFuUqqIE+3e1vLwlob44Q4suvt052DXeNUeAV+1CA0dsY3G2v1ilXv1yWoP907jTvNoI6rld0hm5eM0TO/JcSJoDG4MASWlYWaufehKBzZFS41EzpFAv7q6i74PWGH6e0uInLmxqKp4lz7hji4gu5pRixd9+s3xGNV02NANzcKfzyvKTiB0+X3IE6UVBvfoQVd8f917rnv/DQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkR7GoBglnFwdLrezXZPSkC+Aj7NpdeoUb+CsbPZ6yIOa55dtSiM+Db8rwpNJA856Q4GdL2XUJSJwGZ+pLMy8gf/t7tkLzCSJHd9B/e56N8ODORXRpfytZ94SB6AI+3i2YLCQNdMnSS+hWnR9PUKSVb892Ig7dfA+dwEnDdU+0/6fi9epnh3UcyaRXlCz84THrP3XPpAkx7/AA5BywNaqTO42DJ8R+81EVZc7KBTzpRUDYwCai885DdPhD0Ku/5ZaDObig83jZXKyA5qAmNIhl4qNUosr5xY0cUfXYWygDo9AG9v5SapdmB3vXoWHADdn2GXn8XWYNyiSHXNLJOVLQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 03 Jan 2023 11:18:00 +0000
- Ironport-data: A9a23:UGrBGq7QBOyaeQHbyqLH1AxRtPXGchMFZxGqfqrLsTDasY5as4F+v jAfWDqHa/mKM2qgL9tzbo+3ph4GvMeGztQ3GwNr/Cg9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 tgIED5dMle/u8mI5+KBZvhVudYPM5y+VG8fkikIITDxK98DGMmGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ok0ooj+KF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJDReXgqq806LGV7kc9VzAqalGJm6mkkm3iasNkD WM56BN7+MDe82TuFLERRSaQpXeeuxcGVtl4Eusk6RqMwK7Z/waYAGcfSjdLLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcmZwYY59jooKkokwnCCN1kFcadkdndCTz2h TeQo0ADa647iMcK0+C3+A7Bijf1/5zRFFdqvEPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytYVUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:rovTC62V3ljUhsoG425UlQqjBZxxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrGG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkjd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nV6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklVavoXRiKrLzPIt MeSv0018wmKG9yqEqp5lWH9ebcGUjb2C32GXTq9PbliQS+10oJsnfwjPZv4kvosqhNCKWsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkf0IDU6RCe41JbYJ6e L8uWljxCcPUlOrDdfL0IxA8xjLTmn4VTPxyttG75w8vrHnXrLkPSCKVVhryqKb0r8iK9yeX+ z2NINdAvflI2erEYFV3xfmU50XLXUFSsUattsyRlrLqMPWLY/hsPDdbZ/oVfHQOCdhXnm6Dm oIXTD1KskF5ke3WmXgiByUQH/pclyXx+MGLEEbxZlm9GEgDPw+juFOsyXJ2iiiE0wzjoUmOE 1jPbjgjqS34WGr4Geg1RQdBiZg
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZHK8Tc134ZZkfC0SbNIFFZQXGXq6JrR4AgALjd4A=
- Thread-topic: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates
On 01/01/2023 3:10 pm, Marek Marczykowski-Górecki wrote:
> On Sat, Dec 31, 2022 at 12:30:07AM +0000, Andrew Cooper wrote:
>> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
>> index b3fcf4680f3a..d962f384a995 100644
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -346,11 +346,18 @@ void __init early_cpu_init(void)
>> x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86,
>> c->x86_model, c->x86_model, c->x86_mask, eax);
>>
>> - if (c->cpuid_level >= 7)
>> - cpuid_count(7, 0, &eax, &ebx,
>> + if (c->cpuid_level >= 7) {
>> + uint32_t max_subleaf;
>> +
>> + cpuid_count(7, 0, &max_subleaf, &ebx,
>> &c->x86_capability[FEATURESET_7c0],
>> &c->x86_capability[FEATURESET_7d0]);
>>
>> + if (max_subleaf >= 1)
> tabs vs spaces ...
Fixed.
>
> Is this file imported from Linux? It uses tabs for indentation, contrary
> to the rest of the Xen code base.
It is a file which originally inherits from Linux, but it probably has
~0% in common any more...
~Andrew
|
