Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly

[Andre Przywara <andre.przywara@xxxxxxx>]

On Thu, 27 Oct 2022 20:09:13 +0100
Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:

Hi,

> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should 
> be
> used to restore the saved interrupt state.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and 
> property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>

Thanks for fixing this!

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Cheers,
Andre

> ---
>  xen/arch/arm/vgic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index d0e265634e..015446be17 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, 
> mmio_info_t *info,
>              write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>          }
>  
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> +        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>  
>          return 1;
>      }