Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 15/10/2022 06:07, Vikram Garhwal wrote:
[snip]
> +    qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
> +
> +    state->memory_listener = xen_memory_listener;
> +    memory_listener_register(&state->memory_listener, &address_space_memory);
> +
> +    state->io_listener = xen_io_listener;
> +    memory_listener_register(&state->io_listener, &address_space_io);
> +
> +    state->device_listener = xen_device_listener;
> +    QLIST_INIT(&state->dev_list);
> +    device_listener_register(&state->device_listener);
> +
As Julien said, these do not belong here. These are the (current and 
legacy) PV backend setup functions; they most certainly have nothing to 
do with device emulation.
  Paul