[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86emul: add memory operand low bits checks for ENQCMD{,S}
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 19 Jul 2022 20:13:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3RUlfYEfNwp809KR8X2QzXUGlVPuOa8+6cg0oGoco3U=; b=K5K6HE8eyCx6+tY06+ff2pnqMnkhnKeH8TvI1mKN6jMc+aaMLdhMAs8qF8gqoaCqK99OVrhSHjA9JFlVGbUD0ZAFlSoANiUwbr1VFqTQ0qalB5Hx/FxgQRovM1pVuxRV09nkrv9/SErQc/vsvN2u9DfCkxJ7O9bCYA676TXvA9kQ68YfWwxPHFwVEJLFYpzGCcBNks/shYnUoSHZmcZuhkN5lI1aoQP2e4dlwZtakUuLnFXfD2O2q/iyxdijnKL1W0lTqlWo2AXK3DaJMrR+XEyjGmJDzvIwuJ8vdMv/JmdBzP1LTVIRKdEMlGjn7sdNFuyH8YsRlkgJ5t0FoEUD+w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGpqxLh2RGUrXDqv+KFeluhVxHnVm/wZ8j3tjf+nyBlBJtptunOujxmDvvPqPwye7ZV882GAhbxK4DB1eV+qMdHDMnobLFXcQdOFXInyd3nFF3FxyMCuuhB52QPt5iwm10Njy+hU9qOSlEuMkFvj7Qzu/dqJaFRosGw7Fr0aH6YPeRb8ChLkVGDAW8LKfQBP263keUDoaq1/l1/yYG+9vhOu5ZUX/mT2DP41AvImD3PTsckTk8xngp+Lhm7K28ir4oFx95cxk+wcTaYwig6SGO8JiPiYVwxIUnQJhz2DF6N/vtGciEUTnLKmVdEK0lRopNo0g53mJa/mmKE5QQQY9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 20:13:47 +0000
- Ironport-data: A9a23:ZQZFBKPe6Pa+H0TvrR27lsFynXyQoLVcMsEvi/4bfWQNrUomhWcOz DMcXGrVO/uOZGrxfdoib42+8R9SsJTczoc3TQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPvS8EgHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPw868tJgISAbQxpM13BH9O7 NA1azcSO0Xra+KemNpXS8FKr+F6dozOA9lavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rn2wCWhG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFaYDBlGLarhpAgMfNjyL8R7sKJoGkrN5zx3uLmFISAREvAA7TTf6RzxTWt8hkA 04e9zcqrKMy3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebSMu/ k+EmZXuHzMHjVGOYXeU97PRqCzoPyEQdDUGfXVcEVVD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zly/sr6Nhu+hWLOYWg==
- Ironport-hdrordr: A9a23:r6/UGK8ikX2p5WNgJk1uk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYm27yQ3w+gdOvIE6doYW7iaLBhq2GISKA
- Thread-topic: [PATCH] x86emul: add memory operand low bits checks for ENQCMD{,S}
On 19/07/2022 13:56, Jan Beulich wrote:
> Already ISE rev 044 added text to this effect; rev 045 further dropped
> leftover earlier text indicating the contrary:
> - ENQCMD requires the low 32 bits of the memory operand to be clear,
> - ENDCMDS requires bits 20...30 of the memory operand to be clear.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> I'm a little reluctant to add a Fixes: tag here, because at the time
> the code was written the behavior was matching what was documented.
It needs a tag, because this is fixing a problem in a previous patch,
and in principle wants backporting to 4.14.
It doesn't matter the cause of the error, and "Intel changed their
documentation" is pretty good as far as excuses go.
As far as the change goes, that does seem to match the latest docs.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
