[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 11 Jul 2022 15:41:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PT8a6vqWuCNd0plAzJ9mH+Byt7yYLrj7br2ncgocIFg=; b=ZABandyfKfXZc6qqTq2rSMoXoLsuae3aj++TBviP6EiSWGBiPskljm99W+DKBO4xG0FoaAFzazN/4tNB0ayR+mId+kuIBdfCzF4JL5S7xs+7jE7LJIaCb4Xe+UkI93reLvtf/Iav1nM5qDSTGtCSPIvSSVWUz0azbfJ4KExQKzoZypsp6Hjtb2Z5EgG2XbcpIQcbfLDGmWsTmmReRIc5FpfYz9vutC+MRanY0nRJaQiacSwfvi5XF3Y1IW4bQie/bjF2RJvmQIXRxYMURioui4XUlfhe75kUyraq5wy1WcThyx2D1haWStM0Mi/fiDiYNwLctZHLgh+Mdu51076NCQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YR2FWXhb76ubqwZh17IzS7mS+J+0tGglf1BRUHvscUwpjGoBBGVSEjetPPocWSBTHyEDHAOT+ruNj1JfbpO1ekzGBwjUSK+YSdaE6xy6VSVagjez35ZxLBTJNGRJKjU/ymqD6SfeO1ZgZAZT0jwhC81qqCYvUY3+aH143Ohn/cnl4bmi5wL0L85RtAazS3zj0OFUn5muR6v6euy5ObMWW5cB9gPEpchx8LKfuFvtVSXGP874azc2LvPpM4AgXNPE4cydn0TCV9p9SwVHKVtypDr5EQnVO2iah/PC/V/AlwgH+CBdxw3e/+yHYViGJ2YwvB7U7iOjWI3SdUE6Qg2mQQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 11 Jul 2022 13:41:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.07.2022 17:39, Luca Fancellu wrote:
>> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>> @@ -87,21 +89,21 @@ roms.inc: $(ROMS)
>>
>> ifneq ($(ROMBIOS_ROM),)
>> echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new
>> - sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
>> echo "#endif" >> $@.new
>> endif
>>
>> ifneq ($(STDVGA_ROM),)
>> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
>> - sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >>
>> $@.new
>> echo "#endif" >> $@.new
>> endif
>> ifneq ($(CIRRUSVGA_ROM),)
>> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
>> - sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga
>> $(CIRRUSVGA_ROM) >> $@.new
>> echo "#endif" >> $@.new
>> endif
>> - mv $@.new $@
>> + mv -f $@.new $@
>
> Here, instead of -f, is it safer -u? What’s your opinion on that? The patch
> looks good to me.
Would -u be an option to use in the first place? It's not a standard
option to mv, afaict.
Jan
|
