Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

[Julien Grall <julien@xxxxxxx>]

Hi Xenia,

On 05/07/2022 22:02, Xenia Ragiadakou wrote:
> The function idle_loop() is referenced only in domain.c.
> Change its linkage from external to internal by adding the storage-class
> specifier static to its definitions.
>
> Since idle_loop() is referenced only in inline assembly, add the 'used'
> attribute to suppress unused-function compiler warning.
>
> Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

> ---
>   xen/arch/arm/domain.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2f8eaab7b5..2fa67266d0 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -63,7 +63,7 @@ static void do_idle(void)
>       rcu_idle_exit(cpu);
>   }
>   
> -void idle_loop(void)
> +static __used void idle_loop(void)
>   {
>       unsigned int cpu = smp_processor_id();
>   
--
Julien Grall