Re: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building

[Julien Grall <julien@xxxxxxx>]

On 01/07/2022 11:34, Jan Beulich wrote:
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >   xen/arch/arm/efi/Makefile | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
> > index dffe72e589..b06fb96c1f 100644
> > --- a/xen/arch/arm/efi/Makefile
> > +++ b/xen/arch/arm/efi/Makefile
> > @@ -1,5 +1,9 @@
> >   include $(srctree)/common/efi/efi-common.mk
> >   
> > +ifeq ($(CONFIG_ARM_32),y)
> > +CFLAGS-y += -fno-short-wchar
> > +endif
> Simply
>
> CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar
>
> ? But, as suggested, perhaps further
>
> $(obj)/stub.o: CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar
>
> to make sure we'd notice any other uses / issues here. After all it
> is - at least in theory - possible that Arm32 would also gain EFI
> support, and then it would be a problem if the other ("real") files
> were compiled that way (albeit I think the issue would be easily
> noticeable, as I don't think things would build that way).
Instead of CONFIG_ARM_32, I would use CONFIG_ARM_EFI. So this would also 
work if we want to disable EFI on arm64 or enable on arm32.
Cheers,

--
Julien Grall