Re: [PATCH v2 2/2] public/io: xs_wire: Allow Xenstore to report EPERM

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 27/06/2022 15:52, Juergen Gross wrote:
> On 27.06.22 14:36, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > C Xenstored is using EPERM when the client is not allowed to change
> > the owner (see GET_PERMS). However, the xenstore protocol doesn't
> > describe EPERM so EINVAL will be sent to the client.
> >
> > When writing test, it would be useful to differentiate between EINVAL
> > (e.g. parsing error) and EPERM (i.e. no permission). So extend
> > xsd_errors[] to support return EPERM.
> >
> > Looking at previous time xsd_errors was extended (8b2c441a1b), it was
> > considered to be safe to add a new error because at least Linux driver
> > and libxenstore treat an unknown error code as EINVAL.
> >
> > This statement doesn't cover other possible OSes, however I am not
> > aware of any breakage.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Thanks. I have committed this patch and respin the first one.

Cheers,

--
Julien Grall