[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
- To: Christian Lindig <christian.lindig@xxxxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Wed, 29 Jun 2022 15:53:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dOJWYZSZwxLQ1p14xgUczEAKCz098QDeQcy3Z1ip4dg=; b=VMLgM0nqXopfIgUyhIWVvGoMUZdmA0dM0Nid38Vl4wQTPjL358ITJR2u7DTb8KSGovb6VwQFWSHwu3Ir2CTGuPHpSHmSKs3lZclW1cpHy98k5BXpj51y8wQbu2Y88X3dNlLd4O7bBkFrwuFlVv4OotERThovulT9GCAuwNtPk9tDVaN2tsDugWkWq6IHQvY9bByvfWsWd2tpAxzOlT/dqRrdI7CiU1BwWkDNWr3SrLvmhxpU3h3j668NFZJ6fchhrHO81Af2dWIU4+7jqGPm2dj6PlCs8GmS9ba3/701cJuJzx/2PyvI6mX7OXKcubpkvDJlglxPxue7W63UOK6c3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EU5TN8cPFQRWz8Pt57sPbA4AnLRGgrCrwH/sU5ca2O/JaaIGeKDjQl+MLURZO0Hvao+fVYsJNWvbZ5EOdU6LnkTwzJYMG4dkLVFYAiVJ/hoj4vR3dzeFTWXkniJC+/lsdbVySZCN+RhanWwpKu0/x4y60xxzyD9kSlhXRNKgukV+lAmjaN+zvmbxqXYO1MaIVG/aZVzk23UgxF24hyym3kPQ/leicJQivNW5fPQKOJwj9IdrnYJsxd1t61iQcpNI0PMtbfebw216MRCNT0jL6WlClUV45BQ1aaChLJsZb8urY7SF5t0ckeTW/RZb/OJr75GpzXwuEeZwk7JUba+POQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
- Delivery-date: Wed, 29 Jun 2022 15:54:20 +0000
- Ironport-data: A9a23:7CrCDa0/cDW6y6cqfvbD5VRwkn2cJEfYwER7XKvMYLTBsI5bp2FUn GAWXTuBOP+DMWb1KIp2OYW39koP65Hcx9U1SVA5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1Ek/NtTo5w7Rj2tAy0IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0UrL+gbwEvBJf0lfwUfEZRMjNgIZRJreqvzXiX6aR/zmXgWl60mbBVKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82cBfmajTNb9G5YasRmP//Ya ow8YD5maB3GbjVEO0sNCYJ4l+Ct7pX6W2IE8AnL+/tri4TV5E9o/7jOMMHFRoKhW8gLw12bj zjox12sV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24makXMlVM UsT+SwGoq079UjtRd74NzWnpFaUsxhaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOttIyRDEs/ k+EmZXuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty9vsuoYolTrUU81uVqWyi7XdFTjuz hiQoSM5hrFVitQEv4254FaBhTuvr5rISwcd5wPLU2bj5QR8DKamapKp7x7H7P9GBIefUlSF+ nMDnqCjAPsmCJiMkGmWRrwEGrisv6yBKGeE3Q4pGIQ9/TOw/XLlZZpX/Dx1OEZuNIADZCPtZ 0jQ/whW4fe/IUeXUEO+WKrpY+xC8EQqPY2Nuiz8BjaWXqVMSQ==
- Ironport-hdrordr: A9a23:msYiv6xQUBlSVBy/DxzGKrPxjuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqn12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtqrQe9tQ0tbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MVlVBw6dtP22z6IJyoHUVf7sLTCJTkwono+pv+gfa/erKc qOBA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYi8AZy145ktbIbk+rkdBDuBblea1md2sAgAAR9QA=
- Thread-topic: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
On 29/06/2022 15:49, Christian Lindig wrote:
>
>
> On 29 Jun 2022, at 14:55, Jane Malalane
> <jane.malalane@xxxxxxxxxx<mailto:jane.malalane@xxxxxxxxxx>> wrote:
>
> + physinfo = caml_alloc_tuple(11);
> Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core));
> Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket));
> Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus));
> @@ -749,6 +749,17 @@ CAMLprim value stub_xc_physinfo(value xch)
> Store_field(physinfo, 8, cap_list);
> Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));
>
> +#if defined(__i386__) || defined(__x86_64__)
> + /*
> + * arch_capabilities: physinfo_arch_cap_flag list;
> + */
> + arch_cap_list = c_bitmap_to_ocaml_list
> + /* ! physinfo_arch_cap_flag CAP_ none */
> + /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_X86_MAX max */
> + (c_physinfo.arch_capabilities);
> + Store_field(physinfo, 10, arch_cap_list);
> +#endif
> +
> CAMLreturn(physinfo);
> }
>
> I this extending the tuple but only defining a value on x86? Does this not
> lead to undefined fields on other architectures?
You're right, it's missing a definition, I will send a new version -
will just give some time for more eventual comments from others on the
series overall.
Thank you,
Jane
|
