[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 28 Jun 2022 14:10:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btgu3gFaOZvs/7oOpXmKYmRQ9KcHhN6NVAvkKMpBd8E=; b=RUI3ijXShf47jm+fmsiEd7RCO7e6tFYYqt12yZl0ovTD5bVr2VBM6k7Daf+iid1BmSjo6ca5oAKvxE/7rqhE6AnsRabAccC0m4Q/z+jEzd/S5Kc9NpkFgos4mNuDi2PTiVjP48CCKFXKoSbynI1pO/LPBr6woNG2Pg+rCWH5+Uxzz4WlIRQT05b7TJE9JEh9bApPI54Fd+XUDJfBZGUkt8pj2Sv1FZMGH0PHISbWnx4VCF7tm9sQ0TAJLqCxDDxecKHhcq7/DwhyXGsDnCN8WLDyeaTELy4OC1lZO8/DsWEgSZ4YGaUpp7WuMmD5JYYxFpQtdCx0yekGfRjEKmYhMg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btgu3gFaOZvs/7oOpXmKYmRQ9KcHhN6NVAvkKMpBd8E=; b=iEj5/u7VWyKIq3eBmZGIZJdO3eV+Iv/TIvhWgHGZ4unCrjDH8+bTM6aZ5y0mnm3GvfiHmcx2AJ8aJNWVztnlEYU+mAlRIo84ZZn4OvMSwYpZuW+pVOwjRcqXvnYIPR8DgRhNBka9+iKEMrT2TlNFHxpm0AN5VxBe+I3hWIXxBlF116MM+H6KeG4fr8AnKG60DNlgIm2D5J+xT8OaEM066adj3NAZaGsBb1a9uIbjF/B9HC8C/CWVDmCUmGDaSFYtCI+s4NcKMD67frAMtxPF5jiaEA2raeTxtxisSiZxgFAUvUVevZVhJiESstS7k8JzBAak0L4/sXbwpyQYyOBRqA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C6EMfvJgI/XbBbzmASxgDRnZ7yPB8MxDFqpE55CInlUg3cPMPbw52OFCMcDpK5DYXvgEiuo+DOQw4G8HVgNQ3EzKlr9whLAET7Brkqpl5n2RY0VsGIlinum3TWfyX6+x7N8z6A21fI34MCHEZajBdOwdmvE3wN88WjKWGQMb9xw9bGNpc1k4m2B+43wTV92PfoGaCM/tkA8bEv5qjLkJx9YzrYI1LZDXESWciLodP7FMk0Xsdo50Q+hkY5yNf731knoPnaGxyDT0rx/KuOcoEqBNhYBxDUPODXSchrfHH0iWPoBNf8cBjTKe2xUN6/LANKu1WAVH6Sr3dndIVQPdig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AW8e7AoRqDFhdZb5vzJZyPd78K5v88JFKw3Rw71Ng5oDtw+PfUGW7xuq9Ib2FTw4DnxWwAwrk4uQEUugW9TSuyptprBF3HeoVUY2fehG27gPuTEWfluAXHc5248b6zideD+k6FK07V6/VIZagoogwE5ezZhl3fymeIJlzB/giccMZLlpeYibKtrlbRH570gxdQVrbk7PZMih8/u47du/bxvrmj29Ez2h7yosNt3T1qHaWdOD+Z1NwAwoo6/hRxtGExoTb4qxQIBbei++/MhjYinF7p3HgOK7Y1+ReFDPns5cQjlnr77/pquLYyfaC6kEXqfrxIEiNq4PbFdhASetfQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 28 Jun 2022 14:11:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYiaFo/vW4vxzYIUWAwsr8WvFDwq1k3nUA
- Thread-topic: [PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations
Hi Xenia,
> On 26 Jun 2022, at 22:11, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
>
> Add a function prototype for do_bad_mode() in <asm/arm64/traps.h> and include
> header <asm/traps.h> in traps.c, so that the declarations of the functions
> do_bad_mode() and finalize_instr_emulation(), which have external linkage,
> are visible before the function definitions.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/arm64/traps.c | 1 +
> xen/arch/arm/include/asm/arm64/traps.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 3f8858acec..a995ad7c2c 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -22,6 +22,7 @@
> #include <asm/hsr.h>
> #include <asm/system.h>
> #include <asm/processor.h>
> +#include <asm/traps.h>
>
> #include <public/xen.h>
>
> diff --git a/xen/arch/arm/include/asm/arm64/traps.h
> b/xen/arch/arm/include/asm/arm64/traps.h
> index 2379b578cb..a347cb13d6 100644
> --- a/xen/arch/arm/include/asm/arm64/traps.h
> +++ b/xen/arch/arm/include/asm/arm64/traps.h
> @@ -6,6 +6,8 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int
> instr_len);
> void do_sysreg(struct cpu_user_regs *regs,
> const union hsr hsr);
>
> +void do_bad_mode(struct cpu_user_regs *regs, int reason);
> +
> #endif /* __ASM_ARM64_TRAPS__ */
> /*
> * Local variables:
> --
> 2.34.1
>
|
