Xen project Mailing List

Re: [Viryaos-discuss] [PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

From: Ayan Kumar Halder <ayankuma@xxxxxxx>

Date: Mon, 27 Jun 2022 10:15:04 +0100

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4UBn0p/7StPmtkjZOa+mAy0AOnP5Z686T6X4+RveO/o=; b=eRQQYChpUXVepf5dFoWmwIGVd4WNRTwAbwTKor+v8I3YNzhDUpTpDuNZcnG+cKJnolyGhekPsDfBMgnSKNbCJk2gP6dUkd3RMgq9S/QH43OOgtedrsSVMVsbBES+md/qclPXErIcw/pWu5Pm+9G4nBJxxOLjea3dC9xb0zxY92jq0PzRSJ9+iJR4ghWYSbJcP7JT6ikpI9S5MalJC27zlIgEaxv15NdGPA/AKc/Um+Rc8fgBUV5idZLL/Pe8t/75COk0yzINiwOltQC98L0l0fqayOjmf4/nv3MK0CGATof1e2D3B0ZD+ThbnAM33/x4bJlrwHjqTWF0L/Cu6btiHw==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT7qFhchU2PzV7GRp+LW/eZXcYIaOeVvWXZcsbH0ulIJTQKTC/xHHHZ9uCqBaounVPA1PQbmwjMuOmqzuFcIpQme78Moy8eeNMcgJ2GlqCQkgIOaFharBj/a4oKHyPUZpj/HJBw3ppz8UGov0mZ3LO8U3JhoelE6si3CXolplz3SLpYlm7pVPaFfSrJWyht+LFX9OYvbbkPB+XfJVoHzo1DlV8pnp2Y+ioAA4f6EWBvkE8XTUtf4+43WwWLoxYFFLUiLO2gQd3oqvxFGZsvaHVgFFmDM6z8me9AZs9tAoiAO3S9CanmbjJTnCGKv5hgfUZ+mesDb5dA9snrCdWK26g==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;

Cc: viryaos-discuss@xxxxxxxxxxxxxxxxxxxxx

Delivery-date: Mon, 27 Jun 2022 09:15:19 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/06/2022 19:45, Xenia Ragiadakou wrote:

To be inline with XEN, do not enable direct mapping automatically for all
statically allocated domains.

Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Reviewed-by: Ayan Kumar Halder <ayankuma@xxxxxxx>

---
  README.md                | 4 ++--
  scripts/uboot-script-gen | 8 ++------
  2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/README.md b/README.md
index cb15ca5..03e437b 100644
--- a/README.md
+++ b/README.md
@@ -169,8 +169,8 @@ Where:
    if specified, indicates the host physical address regions
    [baseaddr, baseaddr + size) to be reserved to the VM for static allocation.

-- DOMU_DIRECT_MAP[number] can be set to 1 or 0.

-  If set to 1, the VM is direct mapped. The default is 1.
+- DOMU_DIRECT_MAP[number] if set to 1, enables direct mapping.
+  By default, direct mapping is disabled.
    This is only applicable when DOMU_STATIC_MEM is specified.

- LINUX is optional but specifies the Linux kernel for when Xen is NOT

diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index 085e29f..66ce6f7 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -52,7 +52,7 @@ function dt_set()
              echo "fdt set $path $var $array" >> $UBOOT_SOURCE
          elif test $data_type = "bool"
          then
-            if test "$data" -eq 1
+            if test "$data" == "1"
              then
                  echo "fdt set $path $var" >> $UBOOT_SOURCE
              fi
@@ -74,7 +74,7 @@ function dt_set()
              fdtput $FDTEDIT -p -t s $path $var $data
          elif test $data_type = "bool"
          then
-            if test "$data" -eq 1
+            if test "$data" == "1"
              then
                  fdtput $FDTEDIT -p $path $var
              fi
@@ -491,10 +491,6 @@ function xen_config()
          then
              DOMU_CMD[$i]="console=ttyAMA0"
          fi
-        if test -z "${DOMU_DIRECT_MAP[$i]}"
-        then
-             DOMU_DIRECT_MAP[$i]=1
-        fi
          i=$(( $i + 1 ))
      done
  }

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.