[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Jun 2022 07:18:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VavmEi37OZUroXHyeVtCogpRzg00xa26FE5rlldmerY=; b=QRIOSneN2jbUBMLsfeJ2ncyb69SSpZtKmLgKD+/SCtGQW7gudxIRt8JLQAUMyGpAOketbeKz3b6hJ145QVkYulwi5lKNymvXV7f74d2Wen6xhvycw/wP8RRP98liq84N6sz7Xcgqx0I7Y8HM4V8muHfyU+LhWUTwZa6TY4koeAe2lvKZQdes1FLMTMusvBinJq5EVJemiy6FQsv5Dy6PWN+Q9urB863AVL2yqSD1ZSqmnamGARH+MXMsl1C7lSQIGVjNjKSjF0NXRrs8S/yoR/bp3dzSQB99s0DYhTHcnx2SCqJk7CcXfhyzjpgn8XCvW9gr9Ui0RhSwA+LWBe7VvA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VavmEi37OZUroXHyeVtCogpRzg00xa26FE5rlldmerY=; b=jub4dJrmZYKD/nyrVOuJehVhdRkDiEMTpD32+y2KW69p1GP3tPP6SuorljbdFvynO29Pv4g82k6E+SUINHuv1v3TEnhG2O/fP2HLNYxwkicFzHywAUDjffMj7Y9iGVfiNEYhA0wSH1kjAwklATnEOgXPsqABs00ZLohXzTXssY0K8JOaKtzVSKBXCpK5u6yXIGSwvZ0M7DWJe/weVC5/gKO1eX45z7SdxZ5enxvjrO6e5gC878iyMjlq/CUKSqKxocMjA3gfS73z8o/L0jDenxc7ZgpfgxjL5QP5n8BV0Edsm/l0itAyuLVygT3qJ39dORql5et1pB1NSg1LPESjNA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EJKkbG9e6olcuomH8M4sCiF1Klw5ap9LexGYbfiUYiDbGpSgkqSPQ1HcHj3z54Tbam79PgzaaO4vIoo6ozjJrAGC3LY+GUgEpJ33OoQgggiQKug5n+pw9t596uMYtyOWXgG/H2h3HthPA6iTzUONzWUnsTETmGnOP7t2fXghQ4hGRuue66qPBnEBbIoTHStnufVwUE5lYgrEqRbl3zzv7wrnW8gPVJiWxkK8x1rxWV/p9RKZsd1vZcT5wYUDfsRumwUQNJbEVsIDiqf4LHuQ+nwz06pV01tNzhC9gfVMg+ks3Gtu58Rw8W1fdFQxQ2IMKyqA7omCZxiW2lOz3VnaiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IXlx62mNybQkSuKf/W/wse2tYqlQdkoAESv8kkox4Hn7F4lHPveUYTOtAKxh2qO+LPTr4x9KoOpuHmDc1W5xQ66f5Q/c7QbcBQMDNId+Qsuynf6tuWz/LtlQPceM+90iP/FlB8jgGTVM1PDJ7EjzbEQGArzBp/vx+1mg9fb8CA7trqIM8IMPn6azqljMnyeOhmVsmVcveQu/3k0CYwwoulO42F1HylCL78Vu2A5ZP6qzJBUy/S5eCyn+OWzLfx3s+DbuovD79l0zJulhKEcis/MaHpojdf3GPUskeh/n+x5TSCzmGQqX8PWEpXpQyq2u4IhZ5kZPmpJTO+z497g64w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jiamei Xie <Jiamei.Xie@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 24 Jun 2022 07:19:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYfI531SRNO5A+8Ei3iOFoJrK02K1dB3iAgAE0OjA=
- Thread-topic: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年6月23日 20:54
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; Wei
> Liu <wl@xxxxxxx>; Jiamei Xie <Jiamei.Xie@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm
>
> On 10.06.2022 07:53, Wei Chen wrote:
> > --- a/xen/arch/arm/Makefile
> > +++ b/xen/arch/arm/Makefile
> > @@ -1,6 +1,5 @@
> > obj-$(CONFIG_ARM_32) += arm32/
> > obj-$(CONFIG_ARM_64) += arm64/
> > -obj-$(CONFIG_ARM_64) += efi/
> > obj-$(CONFIG_ACPI) += acpi/
> > obj-$(CONFIG_HAS_PCI) += pci/
> > ifneq ($(CONFIG_NO_PLAT),y)
> > @@ -20,6 +19,7 @@ obj-y += domain.o
> > obj-y += domain_build.init.o
> > obj-y += domctl.o
> > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
> > +obj-y += efi/
> > obj-y += gic.o
> > obj-y += gic-v2.o
> > obj-$(CONFIG_GICV3) += gic-v3.o
> > --- a/xen/arch/arm/efi/Makefile
> > +++ b/xen/arch/arm/efi/Makefile
> > @@ -1,4 +1,12 @@
> > include $(srctree)/common/efi/efi-common.mk
> >
> > +ifeq ($(CONFIG_ARM_EFI),y)
> > obj-y += $(EFIOBJ-y)
> > obj-$(CONFIG_ACPI) += efi-dom0.init.o
> > +else
> > +# Add stub.o to EFIOBJ-y to re-use the clean-files in
> > +# efi-common.mk. Otherwise the link of stub.c in arm/efi
> > +# will not be cleaned in "make clean".
> > +EFIOBJ-y += stub.o
> > +obj-y += stub.o
> > +endif
>
> This has caused
>
> ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is
> to use 4-byte wchar_t; use of wchar_t values across objects may fail
>
> for the 32-bit Arm build that I keep doing every once in a while, with
> (if it matters) GNU ld 2.38. I guess you will want to consider building
> all of Xen with -fshort-wchar, or to avoid building stub.c with that
> option.
>
Thanks for pointing this out. I will try to use -fshort-wchar for Arm32,
if Arm maintainers agree.
Cheers,
Wei Chen
> Jan
|
