[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] xen/arm: shutdown: Fix MISRA C 2012 Rule 8.4 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 22 Jun 2022 15:19:40 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+Rx8v74VzjBt6a8QSS2J8yQqn3HjTq3wmVdtxONqGI=; b=Wr528tyddUGup3UoLcshtyiUnT9FO52RSAp7YM6I0nNjjzERwa/shF4anDnnFgFbyQ18uUuom/2+Xv08UgXVTksi8uTA24Vx0MGHnPxnXScq7x68PAYJ7dnNUbBT3SxPUjQIeS0KOpvlUdLnCfqnGT+50x8xgaUECX+4OLTGk12PEqX8ml3fNnCYOefV/1bcqinaG/RKvWdh9K6xO+kidCbCNwdHw63XmVWL6mZaxZbiXWhAfbCNw7ahxE6RbaXc4aFTpYJ6IecjJCmScuCzz1mldRDKMURm2Yqa32JdeG9U5OuhGPyDuRCjqTYr4HICtTiZqNJ7eTmUy/Ivi/F4gw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+Rx8v74VzjBt6a8QSS2J8yQqn3HjTq3wmVdtxONqGI=; b=QC3D+q6+w4KH+ZS9JK27Osc2HLrhFxZqHqSYLj+Ykk7IQVGBM6z4sfKDxGpfB5GsLD2MP5Cx9OQvYmqR5zynqhzidNODMamF8n+6dRNm/4OCmzKbD75055JlgRQwPG+hTRd2VTnWPzN+Zvbfr1gKYGc4x7IvZ/6p9IR2vwhBK8gmoDAf0WPvo/90VOccwa7SW/+XHGg1PTmfAetYQoZVDwnWYXhPf4QyrITaKNXS42Fwc5Md4n2JzXn+UWE7qjei7LJ+MvadPuE+pRwUTOA+ZkI1fdxkj2h+WkuQXxwXpLH1n5NPPmPj7YDwCInajRr9I4jNnn1xBdE5lCOadwqG3w==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ePAngA9A79tbH/6FJZ8Y/M++mAYNyItu0RlrWBdPyeRogYMiet08k7ycOlRCUju/wAy0i8ivRMfjqW0SKMxaoWlThvmLtlc7BzfIMdDdTiNtgBU7xa6d1ozZLtVU92ygR7jGiwr5oRvlnI69TG88qQ3hc3Fh1LDrjzUm7axcxr8P8StMyvicJ3pCxsLmWeHA7Us5pzD4aBgSzfNdGs0zgk2RL2t4gZ06PplX4d+ibIKDMk5sz9ktPoiGEhTGTISpKAyBGwD25PLMuPi/XN6Z3oXzc+cv8xgVB/4G0TVnhDnY66ULae9EplApGOEbLIzTw4d9eIy9oWXvXct9UOBwJw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cXRkn2E66Ude0nvShXMUTVUiVHt3oDy1h6MW+zzWnRBp/TsE19X7Qe0LmdMN/0OqSozClvBdC7ru5pb4BIx2M1xsH6vhx/u54lwcedeNKPM55gJehPxlYI47/PXHYXiAW2FuusAlSTsmA4O3Ug1az3/vUijB0N8NsLavW/m4UoYj4l0gWkc0cT/B5tYs69QZKabtyoI0TlSktbZJPt5SiFObVJ+FwH55ProNbZPNuhINjL6PXENA0iRKx/bUXLUwYXkejyP5FKhhIY44KToKf2nFbnPzouAx8KS1rKWEcGQKrB0s5J1Q2WRDIIeDNKevuh80F9VJ3Xo/tUJtQScYGw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 22 Jun 2022 15:20:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYhkrv8P1hRqUvVU6u7dH9Ml6t461bimSA
  • Thread-topic: [PATCH 1/3] xen/arm: shutdown: Fix MISRA C 2012 Rule 8.4 violation

Hi Xenia,

> On 22 Jun 2022, at 16:15, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
> 
> Include header <xen/shutdown.h> so that the declarations of the functions
> machine_halt() and machine_restart(), which have external linkage, are visible
> before the function definitions.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> xen/arch/arm/shutdown.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> index 3dc6819d56..5550f50f61 100644
> --- a/xen/arch/arm/shutdown.c
> +++ b/xen/arch/arm/shutdown.c
> @@ -2,6 +2,7 @@
> #include <xen/cpu.h>
> #include <xen/delay.h>
> #include <xen/lib.h>
> +#include <xen/shutdown.h>
> #include <xen/smp.h>
> #include <asm/platform.h>
> #include <asm/psci.h>
> -- 
> 2.34.1
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.