[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tools/include: drop leading underscore from xen_list header


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Mon, 20 Jun 2022 14:35:00 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqzsEmV6kSo5TqA5YhqsX2vWi4HCPrafXmwpwSoqiJk=; b=TKE3FFJURag25E121PbRbsClE+rqLojZQ8URMYmqdiunqP2opsCrkE+KknrmI1JIVhf2b4zSjjiFdmwmhWkjNmRnlhq95jlNdtDgBLdd0oGe1FOH9ieJyZ9SM3Um0C9IezJhPdfkin2p23aDp1ZYbBgG71njopcs9KNt/XhuI/oAgdOT5RRWcsNyYa9suKE3BQLkVExwU/nMXUdS24QrfZwJ4XIUYyjU9dCCr2EUEBSX6awwHs6FnW1d/jUb37jz+zJonSkzji6BhbtP0JO8Qvz5dWN3J4NE+xvGBVezL0Ohk7sNAq3mEvfaGD5rLGUBE93fgLE8qEnKQPmBYz5P+w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edw1k4evUgB/+3rZjxrHSMSaOD6wBirbfHbGxpL5nzTylRBdclrnpmYMXXrZoXkoJE646+DpBGjaAjnfVw1bdex2wvUZu87wkCDNri2SX38I7w29uEHa4gr8EF0uWI9I/dsNAQInI7cgUHC+IKisor7pP6DdZb+OFc8i0CLKt7AWjAGSNOhLU2bjkCkVoM73q/056QJlyi589JajWHoydPyuYAPidTON9rYWrueGTdWbRNaCnuHl+LcXnEl617iHob7o7jGWIr4KSSPymkulk2jpRycWpqz4xOVPIXHpuZjxLg3A65tO27OTdwvMPcKBJFK3dgy4cRQurxUsVpPt+g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Mon, 20 Jun 2022 12:36:31 +0000
  • Ironport-data: A9a23:2zHHeq5pNxyzR0gypFRkGwxRtFPGchMFZxGqfqrLsTDasY5as4F+v mocXDuPbPeDNmugfNpwYdjloB8DuJLcmtQ3GQA4pHs8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YbgXVvR0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSzalwCMoHek94+Sh5nVDpdJ4xYqa3udC3XXcy7lyUqclPK6tA2VgQcG9Rd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiTo4MFtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGYD8wjF+/RfD2776BddiZrrANrudc2jd/d8zhrHj 0P3xjGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRolG6c8JSL QoT4CVGhao97kuwVfHmQga15nWDu3Yht8F4FuQ77ESHzPPS6gPBWWwcFGYdNZohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnHr6PzIbdYgXJJAzN
  • Ironport-hdrordr: A9a23:CBvTxKMh6KFwB8BcTyf155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBDpTnmAtj5fZq8z+8N3WB1B9uftWbdyQ+Vxe1ZjbcKoAeQZhEWiNQtsp uIGpIWYLOQMbETt7eB3ODSKadE/DDoytHKuQ+IpE0dNj2CJpsQmDtRO0K+KAlbVQNGDZ02GN 614ddGnSOpfTAyYt6gDncIcuDfr5mT/aiWKCIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7WQywPa1UXU85NK8eGRvOdrNYipsIw4Oz/sggGnaMBIXKCDhik8pKWV5FMjgL D30mUdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxyL5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjxUC3abFuJ4O5kLZvsn+8SPw7bWPHAcEcYa JT5fjnlbprmQjwVQGYgoFtqObcLUjbUC32AXTqgfblrAS+rEoJs3fw+/Zv4EvojKhNLaWsx9 60R5iAx4s+OvP/U8pGdZY8aPryLFDxajTxF0/XCWjbNcg8SgLwQtjMkf0I2N0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

A leading underscore is used to indicate auto generated headers, and
the clean use of 'rm -f _*.h' will remove those.  _xen_list.h also
uses a leading underscore, but is checked in the repo and as such
cannot be removed as part of the clean rule.

Fix this by dropping the leading underscore, so that the header is not
removed.

Fixes: a03b3552d4 ('libs,tools/include: Clean "clean" targets')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 tools/include/Makefile                    | 4 ++--
 tools/include/libxl.h                     | 2 +-
 tools/include/{_xen_list.h => xen_list.h} | 0
 tools/include/xentoolcore_internal.h      | 2 +-
 tools/libs/evtchn/minios.c                | 2 +-
 tools/libs/light/libxl_qmp.c              | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
 rename tools/include/{_xen_list.h => xen_list.h} (100%)

diff --git a/tools/include/Makefile b/tools/include/Makefile
index 3a03a0b0fa..b488f7ca9f 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -70,13 +70,13 @@ install: all
        $(INSTALL_DATA) xen/io/*.h $(DESTDIR)$(includedir)/xen/io
        $(INSTALL_DATA) xen/sys/*.h $(DESTDIR)$(includedir)/xen/sys
        $(INSTALL_DATA) xen/xsm/*.h $(DESTDIR)$(includedir)/xen/xsm
-       $(INSTALL_DATA) _xen_list.h $(DESTDIR)$(includedir)
+       $(INSTALL_DATA) xen_list.h $(DESTDIR)$(includedir)
 
 .PHONY: uninstall
 uninstall:
        echo "[FIXME] uninstall headers"
        rm -rf $(DESTDIR)$(includedir)/xen
-       rm -f $(DESTDIR)$(includedir)/_xen_list.h
+       rm -f $(DESTDIR)$(includedir)/xen_list.h
 
 .PHONY: clean
 clean:
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6cfac..7ce978e83c 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -747,7 +747,7 @@
 typedef struct libxl__ctx libxl_ctx;
 
 #include <libxl_uuid.h>
-#include <_xen_list.h>
+#include <xen_list.h>
 
 /* API compatibility. */
 #ifdef LIBXL_API_VERSION
diff --git a/tools/include/_xen_list.h b/tools/include/xen_list.h
similarity index 100%
rename from tools/include/_xen_list.h
rename to tools/include/xen_list.h
diff --git a/tools/include/xentoolcore_internal.h 
b/tools/include/xentoolcore_internal.h
index deccefd612..1be014434d 100644
--- a/tools/include/xentoolcore_internal.h
+++ b/tools/include/xentoolcore_internal.h
@@ -27,7 +27,7 @@
 #include <stddef.h>
 
 #include "xentoolcore.h"
-#include "_xen_list.h"
+#include "xen_list.h"
 
 /*---------- active handle registration ----------*/
 
diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 8ff46de884..28743cb055 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -20,7 +20,7 @@
  * Split off from xc_minios.c
  */
 
-#include "_xen_list.h"
+#include "xen_list.h"
 #include <mini-os/types.h>
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c
index 8faa102e4d..6b0cd607d8 100644
--- a/tools/libs/light/libxl_qmp.c
+++ b/tools/libs/light/libxl_qmp.c
@@ -63,7 +63,7 @@
 
 #include <yajl/yajl_gen.h>
 
-#include "_xen_list.h"
+#include "xen_list.h"
 #include "libxl_internal.h"
 
 /* #define DEBUG_RECEIVED */
-- 
2.36.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.