[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/9] include/public: Use explicitly specified types


  • To: Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Mon, 20 Jun 2022 10:07:49 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrkBczKJRh0JmtNDuH0h2zEOcWlVs8YN2TqqPR5TdIw=; b=JM/U0dmw8kdZwOJ6rWULDlM6WIqv8H+kLgCSaNX6dYdUodX2Zssf0LugYrLZX8+UOa+H8mzkEpPKUeBy93P3lV0DO+703Em75O/GOXt+TRJKg6dCURC8SBgy7cJkqBNdA1Rs50ZSqlpKwZ6Oy3Na7F8Rep0vOzo+IzC5ohwxcMdlan8/Bft/hDEygQ4LToTzkagk44ayKozDN3DqbGl19N1mEHqxqBEHeAsa9du7KyXdQr7CczwGLC5XjYlbPj9PXc/so08yWo2cbHnHVtIy24/kxe/zv2Ng5bgN9zmCOO9fBoIL75rCHzLYkeKSDSWPSKbDivJyDWXZmJEiF63nFQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DbPoLwKKNm6tfSOWPHXDaZVU5FOY5C6WdVaN1Ly6uA2KsJKwCx4a4b0ncSgXuEqlZHG03HD7NXnEEMRM3olVy4Tp86fWh0LLiOdi5rQpbhg/yo+aqESxxlVI2NsuyvoVHMjYWDkmJIIzWkKWauXmtEZgG0ED6yXWSBRKKzVPIvVp/BqOgBsariWm6wbJ2eb+C7mP499UT11LaEncDV2HO+30bBrub932G4/0UKnV7RiBQGGL9kAFQzeJhY+/vl+gHwT9lqvYtpzF9xhHvvAYMaYPcTAABPXMSiKqbdVBO45DybJ6BVrUu561kdb6BOSJPWGtVII+222e34EIR031nw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 20 Jun 2022 10:07:57 +0000
  • Ironport-data: A9a23:0y3/jKPhR9y1eADvrR2TlsFynXyQoLVcMsEvi/4bfWQNrUorgjNUm GAfUT/TOfmDNGH8fdwjbYm1oE1SscLcn9QySAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFUMpBsJ00o5wbZn29Aw3bBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2 sQKlbvgVwIVA6DtkrkfCkR3NwckFPgTkFPHCSDXXc276WTjKiGp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB4H9afHs0m5vcBtNs0rulIEezTe Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGEE8A/I/vNfD2777CFxjYKyavvuftWAYvlppXuX+ CX08DGsav0dHJnFodafyVqum+vOkCXTSI8UUrqi+ZZChVyYxmUXThoMR1a/ifCjjwi1XNc3A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mlyKDZ/gKYDWgsVSNaZZots8pebScxy laDktftBDpumL6YU3SQ8vGTtzzaETcRBX8PY2kDVwRt3jX4iIQ6jxaKS8k5Fqew14fxAWuon 23MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgPpU KQs8yRG0N0zMA==
  • Ironport-hdrordr: A9a23:pqjpTqs1VwdA4Um+fhktBU+B7skCL4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP v2MI5KApbYXB7TJbo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYhHPXhH2gjwLhME6AOejjpMzR0a1YDrCAgAADlwA=
  • Thread-topic: [PATCH 5/9] include/public: Use explicitly specified types

On 20/06/2022 10:54, Julien Grall wrote:
> Hi Michal,
>
> On 20/06/2022 08:02, Michal Orzel wrote:
>> According to MISRA C 2012 Rule 8.1, types shall be explicitly
>> specified. Fix all the findings reported by cppcheck with misra addon
>> by substituting implicit type 'unsigned' to explicit 'unsigned int'.
>>
>> Bump sysctl interface version.
>
> The sysctl version should only be bumped if the ABI has changed.
> AFAICT switching from "unsigned" to "unsigned" will not modify it, so
> I don't think this is necessary.

Yeah.  No need to bump the interface version for this.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.